AMM: Swap and add liquidity scripts #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supiket
added
New Feature
supiket
changed the title
|
@Braqzen you can take a look at the test-utils :) |
supiket
changed the title
simonr0204
reviewed
Jan 2, 2023
simonr0204
reviewed
Jan 2, 2023
simonr0204
previously approved these changes
Jan 3, 2023
simonr0204
approved these changes
Jan 4, 2023
|
Any extra thoughts here @Braqzen or can we click the big green button? |
Sorry, I was planning on reviewing this tomorrow. Will get around to this soon |
Braqzen
reviewed
Jan 6, 2023
| @@ -54,22 +49,18 @@ pub fn minimum_output_given_exact_input( | |||
| result_wrapped.unwrap() | |||
| } | |||
|
|
|||
| pub fn multiply_div(a: u64, b: u64, c: u64) -> u64 { | |||
| pub fn multiply_divide(a: u64, b: u64, c: u64) -> u64 { | |||
There was a problem hiding this comment.
The name of this function doesn't really convey much as to what it is trying to accomplish. I would rename and potentially add some documentation to outline what is the multiplication and division achieving.
There was a problem hiding this comment.
Cannot come up with a better name now, will rename by the time this is merged to master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Changes
Notes
Before merging to master:
#[should_panic(expected = "Revert(18446744073709486080)")]once feat: support logs from external contracts is mergedfuelsdependencies should be changed to version instead of master branch once new version is outexchange-contract/utils/multiply_dividefunction should be renamed to something along the lines of "proportions"Related Issues
Closes #229
Closes #287