Turn struct field privacy warnings into errors #5520
Assignees
Labels
breaking
May cause existing user code to break. Requires a minor or major release.
compiler: frontend
Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
compiler
General compiler. Should eventually become more specific as the issue is triaged
language feature
Core language features visible to end users
Comments
ironcev
added
compiler
7 tasks
xunilrj
pushed a commit
that referenced
this issue
Feb 8, 2024
## Description Closes #5520. As agreed with @FuelLabs/tooling, one LSP test fixture is changed to temporarily fetch its `std` dependency from the local repository. ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.
sdankel
pushed a commit
that referenced
this issue
Feb 8, 2024
## Description Closes #5520. As agreed with @FuelLabs/tooling, one LSP test fixture is changed to temporarily fetch its `std` dependency from the local repository. ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#5508 treats struct field privacy issues as warnings, to avoid an abrupt breaking change. These warnings must be turned back to errors once enough time is given to programmers to fix them in their code base.
Related to #4692.
The text was updated successfully, but these errors were encountered: