Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn struct field privacy warnings into errors #5569

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Turn struct field privacy warnings into errors #5569

merged 3 commits into from
Feb 8, 2024

Conversation

ironcev
Copy link
Member

@ironcev ironcev commented Feb 7, 2024 •
edited
Loading

Description

Closes #5520.

As agreed with @FuelLabs/tooling, one LSP test fixture is changed to temporarily fetch its std dependency from the local repository.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@ironcev ironcev added compiler General compiler. Should eventually become more specific as the issue is triaged language feature Core language features visible to end users breaking May cause existing user code to break. Requires a minor or major release. compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen labels Feb 7, 2024
@ironcev ironcev self-assigned this Feb 7, 2024
@ironcev ironcev requested review from a team February 7, 2024 22:30
@ironcev ironcev marked this pull request as ready for review February 7, 2024 22:30
@xunilrj xunilrj merged commit 3406358 into master Feb 8, 2024
34 checks passed
@xunilrj xunilrj deleted the ironcev/5520-turn-struct-field-privacy-warnings-into-errors branch February 8, 2024 07:58
sdankel pushed a commit that referenced this pull request Feb 8, 2024
@ironcev @sdankel
Turn struct field privacy warnings into errors (#5569)
3aad2f2 
## Description

Closes #5520.

As agreed with @FuelLabs/tooling, one LSP test fixture is changed to
temporarily fetch its `std` dependency from the local repository.

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esdrubal esdrubal esdrubal approved these changes

@xunilrj xunilrj xunilrj approved these changes

Assignees

@ironcev ironcev

Labels
breaking May cause existing user code to break. Requires a minor or major release. compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler General compiler. Should eventually become more specific as the issue is triaged language feature Core language features visible to end users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Turn struct field privacy warnings into errors
3 participants
@ironcev @xunilrj @esdrubal