Skip to content

Commit

Permalink
Merge pull request #330 from FundingCircle/schema-registry-client-pas…
Browse files Browse the repository at this point in the history
…s-through-allow-property-config

MCPG-231 Do not automatically create a client if none is present:
  • Loading branch information
james-doolan committed Aug 1, 2022
2 parents e0c66d3 + cb20f0d commit d581f0b
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ jobs:
paths:
- .
lint:
executor: machine
machine: true
working_directory: /home/circleci/jackdaw
steps:
- checkout
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,10 @@

### Unreleased

### [0.9.6] - [2022-08-01]

- Add clj-kondo and fix all lint warnings and errors [#323](https://github.com/FundingCircle/jackdaw/pull/323)
- Allow Kafka Schema registry library to create a client rather than do it in Jackdaw (this allows security properties to be recognised) [#330](https://github.com/FundingCircle/jackdaw/pull/330)

### [0.9.5] - [2022-05-26]

Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,3 +48,4 @@ Steps 2 to 6 is essentially `git tag $version -m "$title\n\n$description" && git
Copyright © 2017 Funding Circle

Distributed under the BSD 3-Clause License.

3 changes: 2 additions & 1 deletion project.clj
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@

:url "https://github.com/FundingCircle/jackdaw/"

:repositories [["confluent" {:url "https://packages.confluent.io/maven/"}]]
:repositories [["confluent" {:url "https://packages.confluent.io/maven/"}
"mulesoft" {:url "https://repository.mulesoft.org/nexus/content/repositories/public/"}]]

:dependencies [[aleph "0.4.6"]
[danlentz/clj-uuid "0.1.9"
Expand Down
3 changes: 1 addition & 2 deletions src/jackdaw/serdes/avro.clj
Original file line number Diff line number Diff line change
Expand Up @@ -709,8 +709,7 @@

(let [config {:key? key?
:registry-url url
:registry-client (or client
(registry/client url 128))
:registry-client client
;; Provide the old behavior by default, or fall through to the
;; new behavior of getting the right schema when possible.
:read-only? read-only?
Expand Down

0 comments on commit d581f0b

Please sign in to comment.