MCPG-231 Do not automatically create a client if none is present: #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- kafka api takes care of creating a client if none is specified - if we do create a client here then it does not use some passed through config (such as security)
james-doolan
previously approved these changes
Aug 1, 2022
This reverts commit c540649.
james-doolan
previously approved these changes
Aug 1, 2022
This reverts commit fa13ece.
mattford63
force-pushed
the
schema-registry-client-pass-through-allow-property-config
branch
from
5e5d432
to
74b2da0
Compare
james-doolan
approved these changes
Aug 1, 2022
james-doolan
deleted the
schema-registry-client-pass-through-allow-property-config
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config (such as security)
Checklist