-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update make_bcs legacy input path #718
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biljanaorescanin
added
0 diff
The changes in this pull request have verified to be zero-diff with the target branch.
cleanup
labels
Mar 9, 2023
This was referenced Mar 9, 2023
gmao-rreichle
previously approved these changes
Mar 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Approving for @GEOS-ESM/surface-preproc-team
- @weiyuan-jiang: I noticed that
make_bcs.py
has fallen behindmake_bcs
. It may be good to catch up the python version before there are too many differences to keep straight.
biljanaorescanin
changed the title
update legacy bcs path
update make_bcs legacy input path
Mar 20, 2023
…GEOS-ESM/GEOSgcm_GridComp into feature/borescan_update_legacy_bcs_path
gmao-rreichle
approved these changes
May 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-approving
sdrabenh
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the path to the legacy bcs data by pointing to the new "bcs_shared" directory in the GMAO project space on Discover (replacing
/discover/nobackup/ltakacs/bcs/
)This is the first step in using (legacy) bcs from the new "bcs_shared" dir.
This PR is one of a group of similar PRs:
cc: @gmao-rreichle