Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update make_bcs legacy input path #718

Merged
merged 9 commits into from
May 17, 2023

Conversation

biljanaorescanin
Copy link
Contributor

@biljanaorescanin biljanaorescanin commented Mar 9, 2023

This PR updates the path to the legacy bcs data by pointing to the new "bcs_shared" directory in the GMAO project space on Discover (replacing /discover/nobackup/ltakacs/bcs/ )

This is the first step in using (legacy) bcs from the new "bcs_shared" dir.

This PR is one of a group of similar PRs:

cc: @gmao-rreichle

@biljanaorescanin biljanaorescanin added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. cleanup labels Mar 9, 2023
@biljanaorescanin biljanaorescanin requested review from a team as code owners March 9, 2023 18:38
gmao-rreichle
gmao-rreichle previously approved these changes Mar 9, 2023
Copy link
Contributor

@gmao-rreichle gmao-rreichle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Approving for @GEOS-ESM/surface-preproc-team
  • @weiyuan-jiang: I noticed that make_bcs.py has fallen behind make_bcs. It may be good to catch up the python version before there are too many differences to keep straight.

@biljanaorescanin biljanaorescanin changed the title update legacy bcs path update make_bcs legacy input path Mar 20, 2023
Copy link
Contributor

@gmao-rreichle gmao-rreichle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approving

@sdrabenh sdrabenh merged commit 8e16314 into develop May 17, 2023
@sdrabenh sdrabenh deleted the feature/borescan_update_legacy_bcs_path branch May 17, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants