Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update legacy bcs path #212

Merged
merged 6 commits into from
May 12, 2023
Merged

update legacy bcs path #212

merged 6 commits into from
May 12, 2023

Conversation

biljanaorescanin
Copy link
Contributor

@biljanaorescanin biljanaorescanin commented Mar 9, 2023 •
edited by gmao-rreichle
Loading

This PR updates the path to the legacy bcs data by pointing to the new "bcs_shared" directory in the GMAO project space on Discover (replacing /discover/nobackup/ltakacs/bcs/ )

This is the first step in using (legacy) bcs from the new "bcs_shared" dir.

This PR is one of a group of similar PRs:

cc: @gmao-rreichle

@biljanaorescanin biljanaorescanin added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Mar 9, 2023
@biljanaorescanin biljanaorescanin requested a review from a team as a code owner March 9, 2023 18:59
This was referenced Mar 9, 2023
Merged
Merged
Merged
Merged
@biljanaorescanin biljanaorescanin changed the base branch from main to develop April 11, 2023 19:05
amdasilva
amdasilva previously approved these changes May 12, 2023
View reviewed changes
Copy link
Collaborator

@amdasilva amdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this, although it does not conform to the refactored ExtData file structure. The O3 is obsolete and will be retired in the near future.

@amdasilva
Update CHANGELOG.md
c463e87 
This mod is kind of irrelevant because O3 is scheduled to be retired.
@amdasilva amdasilva merged commit 8af7dd1 into develop May 12, 2023
@amdasilva amdasilva deleted the feature/borescan_update_legacy_bcs_path branch May 12, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amdasilva amdasilva amdasilva left review comments

Assignees
No one assigned
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@biljanaorescanin @amdasilva