Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added AMIP.20C emission scenario #120

Merged
merged 4 commits into from
Mar 14, 2022

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Mar 14, 2022

This branch is a copy of feature/adasilva/#113/AMIP.20C. For some reason, things went wonky in #116 (the branch has an extra / at the beginning in that PR) and the CI is confused...and I can't figure out how to fix that. As far as git is concerned, that / isn't there, but GitHub on the PR page seems to think it is!

@mathomp4 mathomp4 self-assigned this Mar 14, 2022
@mathomp4 mathomp4 added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. enhancement New feature or request labels Mar 14, 2022
@mathomp4 mathomp4 marked this pull request as ready for review March 14, 2022 15:57
@mathomp4 mathomp4 requested a review from a team as a code owner March 14, 2022 15:57
@mathomp4 mathomp4 linked an issue Mar 14, 2022 that may be closed by this pull request
@mathomp4 mathomp4 requested a review from a team as a code owner March 14, 2022 16:06
sdrabenh
sdrabenh previously approved these changes Mar 14, 2022
tclune
tclune previously approved these changes Mar 14, 2022
Copy link
Contributor

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmake changes ok

@amdasilva amdasilva dismissed stale reviews from tclune and sdrabenh via d9060f2 March 14, 2022 18:09
Copy link
Collaborator

@amdasilva amdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, after replacing copies of identical rc files with symlinks.

@mathomp4 mathomp4 requested review from sdrabenh, a team and tclune March 14, 2022 18:52
Copy link
Contributor

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmake changes ok

@amdasilva amdasilva merged commit dd1671c into develop Mar 14, 2022
@amdasilva amdasilva deleted the feature/adasilva/#113/AMIP.20C-copy branch March 14, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop gap fix for EMIP runs: create AMIP.20C emission scenario
4 participants