Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(logging): Repair the logging backend #1695

Merged
merged 4 commits into from
Feb 19, 2024
Merged

fix(logging): Repair the logging backend #1695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
158ed75
fix(logging): Repair the logging backend
MichaelsJP Feb 18, 2024
9e29a1e
fix(maven): Add spring-boot-starter-validation as it was missing
MichaelsJP Feb 18, 2024
7528db4
fix(maven): Remove unnecessary exclusion
MichaelsJP Feb 18, 2024
f7ccbfd
Merge branch 'main' into fix/log4j-slf4j-logging-issues
takb Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions ors-api/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,11 +152,6 @@
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-reload4j</artifactId>
<scope>runtime</scope>
</dependency>

<dependency>
<groupId>org.json</groupId>
Expand Down Expand Up @@ -189,7 +184,11 @@
</exclusion>
</exclusions>
</dependency>

<!-- The following dependency is needed for the Spring Boot Actuator and validates beans -->
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-validation</artifactId>
</dependency>
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-test</artifactId>
Expand Down Expand Up @@ -243,12 +242,10 @@
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-log4j2</artifactId>
<exclusions>
<exclusion>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-slf4j2-impl</artifactId>
</exclusion>
</exclusions>
<!-- Don't exclude log4j-slf4j2-impl -->
<!-- This implements log4j logging as well as proper forwarding from slf4j to log4j -->
<!-- It is necessary when artifacts in the dependency tree use slf4j but we use log4j -->
<!-- Right now, we use log4j2 as logging framework but the graphhopper library uses slf4j -->
</dependency>
<dependency>
<groupId>io.micrometer</groupId>
Expand Down
11 changes: 0 additions & 11 deletions ors-engine/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,21 +133,10 @@
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-reload4j</artifactId>
<scope>runtime</scope>
</dependency>

<dependency>
<groupId>me.tongfei</groupId>
<artifactId>progressbar</artifactId>
<exclusions>
<exclusion>
<groupId>org.jline</groupId>
<artifactId>jline</artifactId>
</exclusion>
</exclusions>
</dependency>

<dependency>
Expand Down
7 changes: 0 additions & 7 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,13 +261,6 @@
<artifactId>slf4j-api</artifactId>
<version>${slf4j.version}</version>
</dependency>

<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-reload4j</artifactId>
<version>${slf4j.version}</version>
</dependency>

</dependencies>
</dependencyManagement>

Expand Down
Loading