-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some minor bug fixes (Senko) #15
base: Senko
Are you sure you want to change the base?
Conversation
Thanks for your pull request! I will review this later. However, I'm busy for another project that has a deadline, so it may takes long time to deal with it. I will do it as soon as possible. Thanks for your corporation! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With your changes, Figura no longer emits errors. However, your change which fixes the problem with First Person Model and Real Camera doesn't seem to work. Can you fix this?
scripts/general.lua
Outdated
if context == "MINECRAFT_GUI" then | ||
shouldRenderHead = true | ||
end | ||
models.models.main.Avatar.Head:setVisible(shouldRenderHead) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I retried it and it didn't have any problems
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick question, have you uploaded your model to Figura's servers before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If so, you may need to reset your model and re-upload it first, otherwise it will be the old code model that is used
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick question, have you uploaded your model to Figura's servers before?
I tested the avatar with your changes.
This is tested with the local avatar. (Actually, my global avatar is another one.) I think that this problem doesn't matter if the avatar is local or global.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
hmmmmmm, that's weird, this thing is working fine on my client, please wait, I'll check again |
Which Minecraft version and mod loader (Forge, Fabric, etc.) are you using? Some minor things may be deferent depending on witch Minecraft version and mod loader you are using. |
The head problem seems to be occurred with First Person Model v2.3.4. This is no longer occurred if the mod is downgraded to v2.3.3. This may be the mod's problem...? |
I submitted this issue to First-person Model repository. |
I'm using the latest version of Fabric (0.15.7), tested on both 1.20.2 and 1.20.4 |
Looks like it should be .... |
Okay, I've added more context checks based on the developer's tips, and now the rendering in the shadow and Figura GUI should all be working correctly |
I also realized that RealCamera seems to come with some compatibility options and perspective shifting, so maybe this could be a direct solution to the head model rendering errors? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More context checking has been added, which should fix all the rendering issues this time around
scripts/general.lua
Outdated
if context == "MINECRAFT_GUI" then | ||
shouldRenderHead = true | ||
end | ||
models.models.main.Avatar.Head:setVisible(shouldRenderHead) |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
scripts/general.lua
Outdated
if context == "MINECRAFT_GUI" then | ||
shouldRenderHead = true | ||
end | ||
models.models.main.Avatar.Head:setVisible(shouldRenderHead) |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
scripts/general.lua
Outdated
if context == "MINECRAFT_GUI" then | ||
shouldRenderHead = true | ||
end | ||
models.models.main.Avatar.Head:setVisible(shouldRenderHead) |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
scripts/general.lua
Outdated
if context == "MINECRAFT_GUI" then | ||
shouldRenderHead = true | ||
end | ||
models.models.main.Avatar.Head:setVisible(shouldRenderHead) |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Okay. I will review your changes tomorrow. Good night. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the result of your code that you want me to try.
[lua] Vinny_san: Context: OTHER
[lua] Vinny_san : FirstPerson: true
[lua] Vinny_san : Head Visible true
[lua] Vinny_san : Context: FIRST_PERSON
[lua] Vinny_san : FirstPerson: true
[lua] Vinny_san : Head Visible false
[lua] Vinny_san : Context: PAPERDOLL
[lua] Vinny_san : FirstPerson: true
[lua] Vinny_san : Head Visible true
[lua] Vinny_san : Context: OTHER
[lua] Vinny_san : FirstPerson: true
[lua] Vinny_san : Head Visible true
[lua] Vinny_san : Context: FIRST_PERSON
[lua] Vinny_san : FirstPerson: true
[lua] Vinny_san : Head Visible false
[lua] Vinny_san : Context: PAPERDOLL
[lua] Vinny_san : FirstPerson: true
[lua] Vinny_san : Head Visible true
According this, the head of the avatar is hidden in FIRST_PERSON
context. However, the head in first person perspective is controlled in OTHER
context, so can you try if you can hide the head in OTHER
context?
However, this causes another problem. As I said, the shadow of the head isn't shown if the head is hidden in OTHER_CONTEXT
. Another solution is make the avatar transparent instead of hiding it, but in this case, some translucent objects like water and colored glass, aren't shown if the camera and the head are overlapped.
According to the case that this problem is no longer occurred in First-person Model 2.3.3 or older, it may be caused by dependent mods. Waiting until it is fixed might be one of solutions.
uhhhh, what other Mods did you use? |
The reason I excluded |
Normally, |
As for the shadow issue, theoretically the Here are the names of all the contexts that can be used to recognize renderer patterns: |
But now that it's fixed, I'll just revert that part of the commit? The author of the issue I submitted with RealCamera also gave me a solution to this problem. |
I tested it again with the following environment:
No other mods are used for testing. However, the issue is still confirmed. |
Is the issue fixed? I still have confirmed the issue with First-person Model. |
hmmmmm, no fix?...Then maybe I misunderstood () |
There may be a discrepancy in our perceptions. The issue that we're discussing is the issue that the head of the avatar is visible in first person perspective with some mods that modifies behaviors in first person perspective, like First-person model and Real Camera. The expected behavior is that the head of the avatar should be hidden in first person perspective. Is my thought correct? |
yep |
First of all, thank you very much for making such a beautiful model !
I found that this model didn't work well on
Figura 0.1.3+
and it didn't work well withFirst Person Model
andReal Camera
mods, after some consulting and learning I fixed both problems and they seem to work perfectly fine now!Since GitHub can only create PRs for one branch at a time, I've created four PRs
This PR is the first PR to fix some problems with
Senko
branching.These PRs might be able to fix some of the problems in the following two Issues (I don't really understand what's wrong with these two Issues due to the language barrier, sorry about that)
Special thanks to ZhuRuoLing for help on the Lua code!