-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some minor bug fixes (Shiro) #16
base: Shiro
Are you sure you want to change the base?
Conversation
Thanks for your pull request! I will review this later. However, I'm busy for another project that has a deadline, so it may takes long time to deal with it. I will do it as soon as possible. Some codes in Shiro are same as Senko's codes. I will resolve this pull request by merging Senko's codes if I can do it. Thanks for your corporation! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With your changes, Figura no longer emits errors. However, the same problem that I mentioned in #15 is occurred. Can you fix this?
end | ||
models.models.main.Avatar.Head:setVisible(shouldRenderHead) | ||
end) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same problem that I mentioned in #15 is occurred. Can you fix this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mentioned about these changes here. Please check it.
PR Introduction: #15
This PR is the second PR to fix some problems with
Shiro
branching.