Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility between black and isort #106

Closed
Galileo-Galilei opened this issue Oct 30, 2020 · 0 comments · Fixed by #107
Closed

Incompatibility between black and isort #106

Galileo-Galilei opened this issue Oct 30, 2020 · 0 comments · Fixed by #107
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Galileo-Galilei
Copy link
Owner

Description

The pre-commit is stuck in an infinite loop: black and flake8 alternatively modify the following line and prevent commits:

from kedro_mlflow.utils import _get_project_globals as get_static_project_data # pragma: no cover

Context

Consequently, it is impossible to commit with the pre-commit installed.

Steps to Reproduce

Try to commit with current requirements (black==19.10b0, isort>=4.0.0, <5.0.0)

Expected Result

The pre-commit should be idempotent (i.e. be appplied identically the second time) and we should be able to commit

Actual Result

Cannot commit.

Solution:

Upgrading to isort>=0.5.0 seems to solve the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant