We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The pre-commit is stuck in an infinite loop: black and flake8 alternatively modify the following line and prevent commits:
kedro-mlflow/kedro_mlflow/framework/cli/cli.py
Line 16 in 18bdb0a
Consequently, it is impossible to commit with the pre-commit installed.
Try to commit with current requirements (black==19.10b0, isort>=4.0.0, <5.0.0)
black==19.10b0
isort>=4.0.0, <5.0.0
The pre-commit should be idempotent (i.e. be appplied identically the second time) and we should be able to commit
Cannot commit.
Upgrading to isort>=0.5.0 seems to solve the problem.
The text was updated successfully, but these errors were encountered:
FIX #106 - Update isort to 5.0.0 to fix conflicts with black
a0f5aa3
e29fe0a
Galileo-Galilei
Successfully merging a pull request may close this issue.
Description
The pre-commit is stuck in an infinite loop: black and flake8 alternatively modify the following line and prevent commits:
kedro-mlflow/kedro_mlflow/framework/cli/cli.py
Line 16 in 18bdb0a
Context
Consequently, it is impossible to commit with the pre-commit installed.
Steps to Reproduce
Try to commit with current requirements (
black==19.10b0
,isort>=4.0.0, <5.0.0
)Expected Result
The pre-commit should be idempotent (i.e. be appplied identically the second time) and we should be able to commit
Actual Result
Cannot commit.
Solution:
Upgrading to isort>=0.5.0 seems to solve the problem.
The text was updated successfully, but these errors were encountered: