Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX #70 - Enforce input schema when logging a PipelineML #107

Merged
merged 2 commits into from
Oct 31, 2020

Conversation

Galileo-Galilei
Copy link
Owner

@Galileo-Galilei Galileo-Galilei commented Oct 30, 2020

Description

This PR close #70 and #106.

Development notes

  • Update the requirements to upgrade isort
  • Update the pre-commit with isort
  • New isortversion modfies a lot of docstring in the codebase
  • Add missing links in the changelog
  • Add a model_signature argument in PipelineML and pipeline_ml_factory whichenable the user to:
    • infer automatically the schema of the input when logging in mlflow (default)
    • do nothing
    • pass a custom made schema for validating both the input and the output

Checklist

  • Read the contributing guidelines
  • Open this PR as a 'Draft Pull Request' if it is work-in-progress
  • Update the documentation to reflect the code changes
  • Add a description of this change and add your name to the list of supporting contributions in the CHANGELOG.md file. Please respect Keep a Changelog guidelines.
  • Add tests to cover your changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@Galileo-Galilei Galileo-Galilei linked an issue Oct 30, 2020 that may be closed by this pull request
@Galileo-Galilei Galileo-Galilei changed the title FIX #70 - FIX #70 - Enforce input shema when logging a PipelineML Oct 30, 2020
@Galileo-Galilei Galileo-Galilei changed the title FIX #70 - Enforce input shema when logging a PipelineML FIX #70 - Enforce input schema when logging a PipelineML Oct 31, 2020
@Galileo-Galilei Galileo-Galilei merged commit 34a4c4f into develop Oct 31, 2020
@Galileo-Galilei Galileo-Galilei deleted the feature/input-signature branch October 31, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibility between black and isort Enforce input signature in pipeline_ml
1 participant