Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MlflowArtifactDataset.load() fails if artifact_path is not None and run_id is specified #362

Closed
Galileo-Galilei opened this issue Oct 3, 2022 · 1 comment · Fixed by #363 or #365
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Galileo-Galilei
Copy link
Owner

Galileo-Galilei commented Oct 3, 2022

Description

When you try to specify an artifact path and a run_id in an MlflowArtifactDataSet, you get an error.

This works:

mlflow_csv_dataset = MlflowArtifactDataSet(
    data_set=dict(type=CSVDataSet, filepath="path/to/df.csv"),
    artifact_path=None,
    run_id="1234",
)
mlflow_csv_dataset .load()

while this :

mlflow_csv_dataset = MlflowArtifactDataSet(
    data_set=dict(type=CSVDataSet, filepath="path/to/df.csv"),
    artifact_path="folder", # this is the difference
    run_id="1234",
)
mlflow_csv_dataset .load()

raises the following error: unsupported operand type(s) for /: 'str' and 'str':

@Galileo-Galilei Galileo-Galilei added the bug Something isn't working label Oct 3, 2022
@Galileo-Galilei Galileo-Galilei self-assigned this Oct 3, 2022
@Galileo-Galilei Galileo-Galilei changed the title MlflowArtifactDataset.load() fails if artifact_path is not None MlflowArtifactDataset.load() fails if artifact_path is not None and run_id is specified Oct 3, 2022
Galileo-Galilei added a commit that referenced this issue Oct 3, 2022
@Galileo-Galilei Galileo-Galilei added this to the 0.11.4 milestone Oct 3, 2022
Galileo-Galilei added a commit that referenced this issue Oct 3, 2022
@Galileo-Galilei
Copy link
Owner Author

The issue is still here when there is nested artifact_path: if the file does not exists, it is downloaded to self._filepath /artifact_path/filename.pkl and cannot be loaded (due to the artifact_path suffix)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment