Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Correctly loads the artifact when both artifact_path and run_id are specified in MlflowArtifactDataSet (#362) #363

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

Galileo-Galilei
Copy link
Owner

Description

Close #362

Development notes

Update MlflowArtifactDataset.load to use Path() object instead of str.

Checklist

  • Read the contributing guidelines
  • Open this PR as a 'Draft Pull Request' if it is work-in-progress
  • Update the documentation to reflect the code changes
  • Add a description of this change and add your name to the list of supporting contributions in the CHANGELOG.md file. Please respect Keep a Changelog guidelines.
  • Add tests to cover your changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@codecov-commenter
Copy link

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (f2206b3) compared to base (d0fd8fc).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #363   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        20    -8     
  Lines          911       893   -18     
=========================================
- Hits           911       893   -18     
Impacted Files Coverage Δ
...dro_mlflow/io/artifacts/mlflow_artifact_dataset.py 100.00% <ø> (ø)
kedro_mlflow/mlflow/__init__.py
kedro_mlflow/io/models/__init__.py
kedro_mlflow/io/artifacts/__init__.py
kedro_mlflow/io/metrics/__init__.py
kedro_mlflow/pipeline/__init__.py
kedro_mlflow/utils.py
kedro_mlflow/framework/hooks/__init__.py
kedro_mlflow/__init__.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Galileo-Galilei Galileo-Galilei merged commit d1a8b2d into master Oct 3, 2022
@Galileo-Galilei Galileo-Galilei deleted the 362-mads-with-artifact-path-and-run-id branch October 3, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MlflowArtifactDataset.load() fails if artifact_path is not None and run_id is specified
2 participants