Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor metrics logging #73

Closed
3 tasks
Galileo-Galilei opened this issue Sep 29, 2020 · 0 comments · Fixed by #227
Closed
3 tasks

Refactor metrics logging #73

Galileo-Galilei opened this issue Sep 29, 2020 · 0 comments · Fixed by #227
Labels
enhancement New feature or request

Comments

@Galileo-Galilei
Copy link
Owner

Galileo-Galilei commented Sep 29, 2020

Currently, the recommended way to log metrics in kedro_mlflow is the MlflowMetricsDataset class.

However:

  • this is not entirely tested and some edge cases fell through the code review. We should make test coverage 100% again.
  • some end users reported their need to have a MlflowMetricsDataset to log an int/ a list directly within the catalog. I suggest that we move almost all the methods (the ones which interacts with the mlflow backend store) to a mother class MlflowAbstractMetricsDataset, and then make MlflowMetricsDataset and MlflowMetricDataset inherits from this mother class and impement just the specific logging.
  • Contrarily to what we choose, it seems that end users prefer having a load_args parameter to specify if they load the whole history (dict of {step: value}), the values (list of int), the last (last int) or the best value.

@akruszewski do you have time/will to address this one as a complement of your previous PR? If yes, add it to the 0.4.0 milestone and assign yourself (even only completing the tests would be really great!).

@Galileo-Galilei Galileo-Galilei added the enhancement New feature or request label Sep 29, 2020
@Galileo-Galilei Galileo-Galilei added this to the Release 0.5.0 milestone Oct 18, 2020
@Galileo-Galilei Galileo-Galilei removed this from the Release 0.5.0 milestone Jan 25, 2021
@Galileo-Galilei Galileo-Galilei modified the milestone: Release 0.6.0 Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant