-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor metrics logging #73
Labels
enhancement
New feature or request
Comments
Galileo-Galilei
added a commit
that referenced
this issue
Oct 23, 2020
Galileo-Galilei
added a commit
that referenced
this issue
Oct 25, 2020
takikadiri
pushed a commit
that referenced
this issue
Oct 25, 2020
9 tasks
Galileo-Galilei
added a commit
that referenced
this issue
Aug 29, 2021
Galileo-Galilei
added a commit
that referenced
this issue
Aug 29, 2021
Galileo-Galilei
added a commit
that referenced
this issue
Aug 29, 2021
Galileo-Galilei
added a commit
that referenced
this issue
Aug 29, 2021
Galileo-Galilei
added a commit
that referenced
this issue
Aug 29, 2021
Galileo-Galilei
added a commit
that referenced
this issue
Aug 29, 2021
Galileo-Galilei
added a commit
that referenced
this issue
Aug 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the recommended way to log metrics in kedro_mlflow is the
MlflowMetricsDataset
class.However:
MlflowMetricsDataset
to log an int/ a list directly within the catalog. I suggest that we move almost all the methods (the ones which interacts with the mlflow backend store) to a mother classMlflowAbstractMetricsDataset
, and then makeMlflowMetricsDataset
andMlflowMetricDataset
inherits from this mother class and impement just the specific logging.load_args
parameter to specify if they load the wholehistory
(dict of {step: value}), thevalues
(list of int), thelast
(last int) or thebest
value.@akruszewski do you have time/will to address this one as a complement of your previous PR? If yes, add it to the 0.4.0 milestone and assign yourself (even only completing the tests would be really great!).
The text was updated successfully, but these errors were encountered: