Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MlflowMetricsDataSet for a better user experience #227

Merged
merged 3 commits into from
Aug 29, 2021

Conversation

Galileo-Galilei
Copy link
Owner

@Galileo-Galilei Galileo-Galilei commented Aug 18, 2021

Description

Close #73

Development notes

  • Create a MlflowAbstractMetricDataSet
  • Create a MlflowMetricDataSet
  • Create a MlflowMetricHistoryDataSet

Checklist

  • Read the contributing guidelines
  • Open this PR as a 'Draft Pull Request' if it is work-in-progress
  • Update the documentation to reflect the code changes
  • Add a description of this change and add your name to the list of supporting contributions in the CHANGELOG.md file. Please respect Keep a Changelog guidelines.
  • Add tests to cover your changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@Galileo-Galilei Galileo-Galilei self-assigned this Aug 18, 2021
@Galileo-Galilei Galileo-Galilei added the enhancement New feature or request label Aug 18, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2021

Codecov Report

Merging #227 (463f9db) into master (d626c8e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #227    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           27        30     +3     
  Lines          791       908   +117     
==========================================
+ Hits           791       908   +117     
Impacted Files Coverage Δ
kedro_mlflow/framework/hooks/pipeline_hook.py 100.00% <100.00%> (ø)
kedro_mlflow/io/metrics/__init__.py 100.00% <100.00%> (ø)
...lflow/io/metrics/mlflow_abstract_metric_dataset.py 100.00% <100.00%> (ø)
kedro_mlflow/io/metrics/mlflow_metric_dataset.py 100.00% <100.00%> (ø)
...mlflow/io/metrics/mlflow_metric_history_dataset.py 100.00% <100.00%> (ø)
kedro_mlflow/io/metrics/mlflow_metrics_dataset.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d626c8e...463f9db. Read the comment docs.

@Galileo-Galilei Galileo-Galilei force-pushed the feature/refactor-metrics branch 4 times, most recently from 2553f16 to 1eecda2 Compare August 29, 2021 10:21
@Galileo-Galilei Galileo-Galilei marked this pull request as ready for review August 29, 2021 21:33
@Galileo-Galilei Galileo-Galilei merged commit c1d9e68 into master Aug 29, 2021
@Galileo-Galilei Galileo-Galilei deleted the feature/refactor-metrics branch August 29, 2021 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor metrics logging
2 participants