Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The CI fails because of setup.pycode coverage #99

Closed
Galileo-Galilei opened this issue Oct 20, 2020 · 0 comments · Fixed by #98
Closed

The CI fails because of setup.pycode coverage #99

Galileo-Galilei opened this issue Oct 20, 2020 · 0 comments · Fixed by #98
Assignees
@Galileo-Galilei
Labels
bug Something isn't working
Milestone
Release 0.4.0

Comments

@Galileo-Galilei
Copy link
Owner

Description

The CI fails because of setup.py

Context

Codecov includes tests folder and setup.py and crashes if you add test that "decrease coverage (typically, empty function)

Steps to Reproduce

Add an empty function in a test

Expected Result

The CI should pass.

Actual Result

The CI fails.

Solution

Ignore tests and setup.py in a codecov.yml file.
Galileo-Galilei added a commit that referenced this issue Oct 20, 2020
@Galileo-Galilei
FIX #99 - Ignore tests and setup.py for coverage
f176178
Galileo-Galilei added a commit that referenced this issue Oct 20, 2020
@Galileo-Galilei
FIX #99 - Ignore tests and setup.py for coverage
429afc7
@Galileo-Galilei Galileo-Galilei mentioned this issue Oct 20, 2020
Merged
9 tasks
@Galileo-Galilei Galileo-Galilei linked a pull request Oct 20, 2020 that will close this issue
Feature/unpack predictions #98
Merged
9 tasks
@Galileo-Galilei Galileo-Galilei self-assigned this Oct 20, 2020
@Galileo-Galilei Galileo-Galilei added this to the Release 0.4.0 milestone Oct 20, 2020
Galileo-Galilei added a commit that referenced this issue Oct 20, 2020
@Galileo-Galilei
FIX #99 - Ignore tests and setup.py for coverage
e5f67e7
@Galileo-Galilei Galileo-Galilei added the bug Something isn't working label Oct 23, 2020
Galileo-Galilei added a commit that referenced this issue Oct 25, 2020
@Galileo-Galilei
FIX #99 - Ignore tests and setup.py for coverage
e092adb
Galileo-Galilei added a commit that referenced this issue Oct 25, 2020
@Galileo-Galilei
FIX #99 - Ignore tests and setup.py for coverage
7398526
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Galileo-Galilei Galileo-Galilei

Labels
bug Something isn't working
Projects
kedro-mlflow roadmap
Status: ✅ Done
Milestone
Release 0.4.0
Development

Successfully merging a pull request may close this issue.

Feature/unpack predictions Galileo-Galilei/kedro-mlflow
1 participant
@Galileo-Galilei