-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/unpack predictions #98
Conversation
5b3bede
to
018196d
Compare
Codecov Report
@@ Coverage Diff @@
## develop #98 +/- ##
===========================================
+ Coverage 97.39% 98.53% +1.14%
===========================================
Files 32 20 -12
Lines 1227 616 -611
===========================================
- Hits 1195 607 -588
+ Misses 32 9 -23 Continue to review full report at Codecov.
|
The coverage decrease is due to a test. I've added a commit to ignore the tests folder in coverage for further PR. |
f176178
to
429afc7
Compare
429afc7
to
e5f67e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just left some remarks in the docs and the predictions's unpacking method, otherwise it's good for me !
e5f67e7
to
e092adb
Compare
e092adb
to
cd16633
Compare
@takikadiri I let you merge when all checks are ok! |
Description
closes #93 #99
Development notes
Compare to what is discussed in #93, I:
KedroPipelineModel
KedroPipelineModel
But I skipped output validation which is much trickier and belong to another PR.
PS: I fixed a few docs typo n the way in a separated commit.
Checklist
CHANGELOG.md
file. Please respect Keep a Changelog guidelines.Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.