Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/unpack predictions #98

Merged
merged 3 commits into from
Oct 25, 2020
Merged

Conversation

Galileo-Galilei
Copy link
Owner

@Galileo-Galilei Galileo-Galilei commented Oct 19, 2020

Description

closes #93 #99

Development notes

Compare to what is discussed in #93, I:

  • make inference pipeline a property to validate it has only one output when set
  • added an output_name attribute in KedroPipelineModel
  • unpacked the result of the predict method of KedroPipelineModel

But I skipped output validation which is much trickier and belong to another PR.

PS: I fixed a few docs typo n the way in a separated commit.

Checklist

  • Read the contributing guidelines
  • Open this PR as a 'Draft Pull Request' if it is work-in-progress
  • Update the documentation to reflect the code changes
  • Add a description of this change and add your name to the list of supporting contributions in the CHANGELOG.md file. Please respect Keep a Changelog guidelines.
  • Add tests to cover your changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@codecov-io
Copy link

codecov-io commented Oct 20, 2020

Codecov Report

Merging #98 into develop will increase coverage by 1.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #98      +/-   ##
===========================================
+ Coverage    97.39%   98.53%   +1.14%     
===========================================
  Files           32       20      -12     
  Lines         1227      616     -611     
===========================================
- Hits          1195      607     -588     
+ Misses          32        9      -23     
Impacted Files Coverage Δ
kedro_mlflow/pipeline/__init__.py 100.00% <ø> (ø)
kedro_mlflow/mlflow/kedro_pipeline_model.py 100.00% <100.00%> (ø)
kedro_mlflow/pipeline/pipeline_ml.py 100.00% <100.00%> (ø)
tests/framework/hooks/test_node_hook.py
tests/framework/cli/test_cli_utils.py
tests/framework/hooks/test_pipeline_hook.py
setup.py
tests/framework/cli/test_cli.py
tests/framework/context/test_mlflow_context.py
tests/io/test_mlflow_dataset.py
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18bdb0a...cd16633. Read the comment docs.

@Galileo-Galilei
Copy link
Owner Author

Galileo-Galilei commented Oct 20, 2020

The coverage decrease is due to a test. I've added a commit to ignore the tests folder in coverage for further PR.

Copy link
Collaborator

@takikadiri takikadiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just left some remarks in the docs and the predictions's unpacking method, otherwise it's good for me !

docs/source/05_python_objects/03_Pipelines.md Outdated Show resolved Hide resolved
docs/source/05_python_objects/03_Pipelines.md Outdated Show resolved Hide resolved
kedro_mlflow/mlflow/kedro_pipeline_model.py Show resolved Hide resolved
@Galileo-Galilei
Copy link
Owner Author

@takikadiri I let you merge when all checks are ok!

@takikadiri takikadiri merged commit e12a74c into develop Oct 25, 2020
@Galileo-Galilei Galileo-Galilei deleted the feature/unpack-predictions branch November 13, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The CI fails because of setup.pycode coverage Managing KedroPipelineModel predictions outputs
3 participants