Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node env configuration should use const as declaration keyword by default #235

Closed
lencioni opened this issue Mar 21, 2016 · 1 comment
Closed

Node env configuration should use const as declaration keyword by default #235

lencioni opened this issue Mar 21, 2016 · 1 comment
Labels
enhancement
Milestone
2.0.0

Comments

@lencioni
Copy link
Collaborator

At least until node gets imports.
@lencioni lencioni mentioned this issue May 2, 2016
Merged
@lencioni
Copy link
Collaborator Author

lencioni commented Jun 2, 2016

Node will support import once it lands in V8 (https://bugs.chromium.org/p/v8/issues/detail?id=1569) and when the loader spec is finalized (http://whatwg.github.io/loader/). Some people say maybe in Node v7 (nodejs/help#53 (comment)).

@lencioni lencioni added this to the 2.0.0 milestone Aug 24, 2016
lencioni added a commit that referenced this issue Aug 24, 2016
@lencioni
Use const as declaration keyword in node environment
4f95200 
This is typical for the node environment, and likely will be until node
gets `import`s. People who are transpiling their code in node can still
override this by setting `declarationKeyword` in their configuration.

Fixes #235
@lencioni lencioni mentioned this issue Aug 24, 2016
Merged
lencioni added a commit that referenced this issue Aug 24, 2016
@lencioni
Use const as declaration keyword in node environment
b2715f3 
This is typical for the node environment, and likely will be until node
gets `import`s. People who are transpiling their code in node can still
override this by setting `declarationKeyword` in their configuration.

In fixing the test, I decided to remove some unnecessary indirection.

Fixes #235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@lencioni