Switch declaration keyword from const to import #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I used the rewrite feature for this conversion. It missed some in lib/importjs.js because we had some code above the imports block so I converted those manually.
| @@ -1,7 +1,7 @@ | |||
| [ | |||
| { | |||
| "environments": ["node"], | |||
| "declaration_keyword": "const", | |||
| "declaration_keyword": "import", | |||
There was a problem hiding this comment.
you can just remove it since it's the default
There was a problem hiding this comment.
I considered that, but I didn't because we have talked about defaulting to const for node env. #235
|
Yeah! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used the rewrite feature for this conversion. It missed some in
lib/importjs.js because we had some code above the imports block so I
converted those manually.