feat: Request Code on EMail and Login using Email and TOTP login #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eshanvaid
changed the title
siddhart1o1
force-pushed
the
login-using-email
branch
from
a019358 to
e6e9493
Compare
siddhart1o1
force-pushed
the
login-using-email
branch
from
36fdd5e to
bf54af8
Compare
sandipndev
previously approved these changes
Jan 19, 2024
siddhart1o1
changed the title
sandipndev
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the user login process by introducing an email-based code request and login mechanism. Upon requesting an email code, the Galoy backend responds with a unique email-login-id after sending the code to the specified email address. In this update, we store this email-login-id in the
.galoy-clifolder. Subsequently, when a user attempts to log in using an email code, they can simply use the--emailflag in the command. The relevant email-login-id will be automatically read from the file, simplifying the login process.Usage-
Note that for the email-based login process using the galoy-cli, it's essential to request the code using the galoy-cli only.