Semantic triggers #162
Merged
Semantic triggers #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I pushed changes to this PR. I'll re-read all the changes tomorrow and merge it, but at least the API should be stable. |
bclement-ocp
added a commit
to bclement-ocp/alt-ergo
that referenced
this pull request
Jun 19, 2023
This patch is an updated version of OCamlPro#652 to be compatible with the new API in Dolmen for accessing the [in] semantic triggers. In addition, the patch also adds proper support for theory extensions, which were previously ignored by the dolmen frontend. There are also some simple tests to ensure that theory extensions and semantic triggers work. It requires that Gbury/dolmen#162 and Gbury/dolmen#165 be merged to work. It also includes OCamlPro#660 because it touches on similar codes and there would be conflicts otherwise.
Gbury
approved these changes
Jun 20, 2023
bclement-ocp
approved these changes
Jun 21, 2023
bclement-ocp
added a commit
to bclement-ocp/alt-ergo
that referenced
this pull request
Jun 21, 2023
This patch adds support for semantic triggers in the dolmen frontend after Gbury/dolmen#162 This is an alternate fix for OCamlPro#677 as it allows the builtin preludes to be parsed with Dolmen.
bclement-ocp
added a commit
to bclement-ocp/alt-ergo
that referenced
this pull request
Jun 21, 2023
This patch adds support for semantic triggers in the dolmen frontend after Gbury/dolmen#162 This is an alternate fix for OCamlPro#677 as it allows the builtin preludes to be parsed with Dolmen.
bclement-ocp
added a commit
to bclement-ocp/alt-ergo
that referenced
this pull request
Jun 23, 2023
Now that Gbury/dolmen#162 and Gbury/dolmen#166 have been merged the build is broken. This patch removes the old In_interval constructor. It was not working properly anyways. Support for the new Semantic_trigger constructor that replaces it in dolmen will land in OCamlPro#681. In addition, this patch is adapted to propagate attributes from the typed statements. This will help determine theory and case-split information in OCamlPro#662.
bclement-ocp
added a commit
to OCamlPro/alt-ergo
that referenced
this pull request
Jun 23, 2023
Now that Gbury/dolmen#162 and Gbury/dolmen#166 have been merged the build is broken. This patch removes the old In_interval constructor. It was not working properly anyways. Support for the new Semantic_trigger constructor that replaces it in dolmen will land in #681. In addition, this patch is adapted to propagate attributes from the typed statements. This will help determine theory and case-split information in #662.
bclement-ocp
added a commit
to bclement-ocp/alt-ergo
that referenced
this pull request
Jun 23, 2023
This patch adds support for semantic triggers in the dolmen frontend after Gbury/dolmen#162 This is an alternate fix for OCamlPro#677 as it allows the builtin preludes to be parsed with Dolmen.
bclement-ocp
added a commit
to bclement-ocp/alt-ergo
that referenced
this pull request
Jun 30, 2023
This patch adds support for semantic triggers in the dolmen frontend after Gbury/dolmen#162 This is an alternate fix for OCamlPro#677 as it allows the builtin preludes to be parsed with Dolmen.
bclement-ocp
added a commit
to OCamlPro/alt-ergo
that referenced
this pull request
Jul 2, 2023
This patch adds support for semantic triggers in the dolmen frontend after Gbury/dolmen#162 This is an alternate fix for #677 as it allows the builtin preludes to be parsed with Dolmen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces in the typechecker the operator
in_intervalby inequalities and binds variables introduced by the symbol?.