-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for check_sat
in the Dolmen frontend
#660
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bclement-ocp
added a commit
to bclement-ocp/alt-ergo
that referenced
this pull request
Jun 19, 2023
This patch is an updated version of OCamlPro#652 to be compatible with the new API in Dolmen for accessing the [in] semantic triggers. In addition, the patch also adds proper support for theory extensions, which were previously ignored by the dolmen frontend. There are also some simple tests to ensure that theory extensions and semantic triggers work. It requires that Gbury/dolmen#162 and Gbury/dolmen#165 be merged to work. It also includes OCamlPro#660 because it touches on similar codes and there would be conflicts otherwise.
bclement-ocp
added a commit
to bclement-ocp/alt-ergo
that referenced
this pull request
Jun 21, 2023
This patch adds support for theory extensions in the Dolmen frontend. It uses Gbury/dolmen#165 and hence requires that to be merged in Dolmen to work. It also includes OCamlPro#660 because it touches similar parts of the code and there would be conflicts otherwise.
4 tasks
Rebased and cleaned version of OCamlPro#594.
bclement-ocp
added a commit
to bclement-ocp/alt-ergo
that referenced
this pull request
Jun 23, 2023
This patch adds support for theory extensions in the Dolmen frontend. It uses Gbury/dolmen#165 and hence requires that to be merged in Dolmen to work. It also includes OCamlPro#660 because it touches similar parts of the code and there would be conflicts otherwise.
bclement-ocp
added a commit
to bclement-ocp/alt-ergo
that referenced
this pull request
Jun 23, 2023
This patch adds support for theory extensions in the Dolmen frontend. It uses Gbury/dolmen#165 and hence requires that to be merged in Dolmen to work. It also includes OCamlPro#660 because it touches similar parts of the code and there would be conflicts otherwise.
Halbaroth
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bclement-ocp
added a commit
to bclement-ocp/alt-ergo
that referenced
this pull request
Jun 26, 2023
This patch adds support for theory extensions in the Dolmen frontend. It uses Gbury/dolmen#165 and hence requires that to be merged in Dolmen to work. It also includes OCamlPro#660 because it touches similar parts of the code and there would be conflicts otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased and cleaned version of #594.