Fix wrap-around error in indexing for matrix-to-grid input #5947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When desired subregion -Rw/e/s/n and a grid's internal region are off by 360 degrees relative to each other, we need to reconcile that before we compute column numbers since gridline vs pixel throws a wrench otherwise. This PR does Adjust teh internal grid header wesn to be compatible with the desired sub region Also updates the objects method when we switch from reference to duplicate (I do'nt think this caused any issues but it is the right thing to).
maxrjones
approved these changes
Nov 4, 2021
There was a problem hiding this comment.
Thanks, this fixes the result for pygmt/tests/test_grdimage.py::test_grdimage_shading_xarray. The only remaining issue here is this example: #5294 (comment), but that's unrelated to this PR.
|
Sorry, not quite sure what you mean (after reading that issue). What is not quite working? |
I'll post an explanation in that issue. This PR is good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5294 for background. When desired subregion -Rw/e/s/n and a grid's internal region are off by 360 degrees relative to each other, we need to reconcile that shift before we compute column numbers since gridline vs pixel registration throws a wrench otherwise (we are off by one column). This PR implements the following:
CLI tests pass, and the pyGMT example returns the correct z-range. Please check that this PR works well for PyGMT, @meghanrjones.