Fix error in indexing for matrix-to-grid input #8554
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Related to #5294 and #5947 and patches #5947.
S_obj->wesn[XLO]
can't be smaller thanG_obj->header->wesn[XLO]
, because at line below:The macro is expanded to something like:
If
S_obj->wesn[XLO] < G_obj->header->wesn[XLO]
, then the result is negative, buti0
is defined asunsigned int
on Linux/macOS. Theni0
has a weird positive value, making the for loop below fail.On Windows, it doesn't have the issue, because
openmp_int
is defined asint
on Windows.