Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Generate images when building docs #6473

Closed
wants to merge 22 commits into from
Closed

Conversation

maxrjones
Copy link
Member

Description of proposed changes

This PR revises the CMake directives to generate the images used in the documentation when building the docs, rather than relying on the dvc-tracked images, when set (NO_DVC TRUE) is used in the CMake configuration.

Fixes #6356

Reminders

  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

@maxrjones maxrjones added the maintenance Boring but important stuff for the core devs label Mar 23, 2022
@maxrjones maxrjones changed the title WIP: Generate images when building docs Generate images when building docs Mar 23, 2022
@maxrjones maxrjones changed the title Generate images when building docs WIP: Generate images when building docs Mar 23, 2022
@maxrjones
Copy link
Member Author

Superseded by #6533

@maxrjones maxrjones closed this May 3, 2022
@seisman seisman deleted the cmake-examples branch May 3, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CMake target to generate images for the docs
1 participant