bugfix for targeting not setting for all adslots (prebid#2615)

* bugfix for targeting not setting for all adslots * updated var names
Genius · Jul 17, 2018 · aed5cae · aed5cae
1 parent b97d2e8
commit aed5cae
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 8 deletions.
diff --git a/src/auctionManager.js b/src/auctionManager.js
@@ -88,6 +88,11 @@ export function newAuctionManager() {
     return getStandardBidderSettings()[CONSTANTS.JSON_MAPPING.ADSERVER_TARGETING];
   };
 
+  auctionManager.setStatusForBids = function(adId, status) {
+    let bid = auctionManager.findBidByAdId(adId);
+    if (bid) bid.status = status;
+  }
+
   function _addAuction(auction) {
     _auctions.push(auction);
   }

diff --git a/src/prebid.js b/src/prebid.js
@@ -166,14 +166,22 @@ $$PREBID_GLOBAL$$.setTargetingForGPTAsync = function (adUnit) {
   }
 
   // get our ad unit codes
-  var targetingSet = targeting.getAllTargeting(adUnit);
+  let targetingSet = targeting.getAllTargeting(adUnit);
 
   // first reset any old targeting
   targeting.resetPresetTargeting(adUnit);
 
   // now set new targeting keys
   targeting.setTargetingForGPT(targetingSet);
 
+  Object.keys(targetingSet).forEach((adUnitCode) => {
+    Object.keys(targetingSet[adUnitCode]).forEach((targetingKey) => {
+      if (targetingKey === 'hb_adid') {
+        auctionManager.setStatusForBids(targetingSet[adUnitCode][targetingKey], BID_TARGETING_SET);
+      }
+    });
+  });
+
   // emit event
   events.emit(SET_TARGETING, targetingSet);
 };

diff --git a/src/targeting.js b/src/targeting.js
@@ -224,11 +224,6 @@ export function newTargeting(auctionManager) {
    */
   function getWinningBidTargeting(adUnitCodes, bidsReceived) {
     let winners = targeting.getWinningBids(adUnitCodes, bidsReceived);
-    winners.forEach((winner) => {
-      winner.status = BID_TARGETING_SET;
-    });
-
-    // TODO : Add losing bids to pool from here ?
     let standardKeys = getStandardKeys();
 
     winners = winners.map(winner => {

diff --git a/test/spec/unit/pbjs_api_spec.js b/test/spec/unit/pbjs_api_spec.js
@@ -376,8 +376,7 @@ describe('Unit: Prebid Module', function () {
     let auction;
     let ajaxStub;
     let cbTimeout = 3000;
-    let auctionManagerInstance = newAuctionManager();
-    let targeting = newTargeting(auctionManagerInstance);
+    let targeting;
 
     let RESPONSE = {
       'version': '0.0.1',
@@ -454,6 +453,8 @@ describe('Unit: Prebid Module', function () {
     })
 
     beforeEach(() => {
+      let auctionManagerInstance = newAuctionManager();
+      targeting = newTargeting(auctionManagerInstance);
       let adUnits = [{
         code: 'div-gpt-ad-1460505748561-0',
         sizes: [[300, 250], [300, 600]],