bugfix for targeting not setting for all adslots #2615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkendall07
reviewed
May 24, 2018
src/prebid.js
Outdated
| @@ -174,6 +174,14 @@ $$PREBID_GLOBAL$$.setTargetingForGPTAsync = function (adUnit) { | |||
| // now set new targeting keys | |||
| targeting.setTargetingForGPT(targetingSet); | |||
|
|
|||
| Object.keys(targeting).forEach((key) => { | |||
| Object.keys(targeting[key]).forEach((key2) => { | |||
| if (key2 === 'hb_adid') { | |||
There was a problem hiding this comment.
why are we only setting bid_targeting_set for winning bid (top bid) when the default in prebid 1.0 is sendAllBids?
There was a problem hiding this comment.
https://gist.github.com/mkendall07/1ef1b27ed3501d7b03fbd72ec455bab4
A bid picked for targeting (prebid auction win) will be marked bid.status = 'targetingSet' - which indicates it's not eligible for future auctions, until such status is cleared. This will prevent a winning bid to be set in targeting more than 1 time.
mkendall07
reviewed
May 24, 2018
src/prebid.js
Outdated
| @@ -174,6 +174,14 @@ $$PREBID_GLOBAL$$.setTargetingForGPTAsync = function (adUnit) { | |||
| // now set new targeting keys | |||
| targeting.setTargetingForGPT(targetingSet); | |||
|
|
|||
| Object.keys(targeting).forEach((key) => { | |||
| Object.keys(targeting[key]).forEach((key2) => { | |||
There was a problem hiding this comment.
you should name things better :)
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* bugfix for targeting not setting for all adslots * updated var names
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* bugfix for targeting not setting for all adslots * updated var names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Targeting was not getting set for all adSlots. We were setting
targetingSetstatus in the wrong function.