Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snap: update for core24 #975

Merged
merged 7 commits into from
Jun 18, 2024
Merged

snap: update for core24 #975

merged 7 commits into from
Jun 18, 2024

Conversation

soumyaDghosh
Copy link
Contributor

No description provided.

.github/workflows/build.yml Outdated Show resolved Hide resolved
@GeopJr
Copy link
Owner

GeopJr commented Jun 9, 2024

Thanks for this PR!

FWIW, this action and snap are only for ci artifacts and development builds. The release snap config lives at https://github.com/GeopJr/tuba-snap/ (you don't have to open a PR there, I'll pick the changes from here!)

@soumyaDghosh
Copy link
Contributor Author

Thanks for this PR!

FWIW, this action and snap are only for ci artifacts and development builds. The release snap config lives at https://github.com/GeopJr/tuba-snap/ (you don't have to open a PR there, I'll pick the changes from here!)

You cannot directly build this in the snapcraft.io website builder. Because gnome extension still experimental.

@GeopJr
Copy link
Owner

GeopJr commented Jun 9, 2024

:/ disappointing

@soumyaDghosh
Copy link
Contributor Author

:/ disappointing

Actually the extensions are getting a major overhaul on the graphics side, with new graphics drivers. So, it's taking this long.

canonical/snapcraft#4744

@soumyaDghosh
Copy link
Contributor Author

You can get the login cradentials via this command,

snapcraft export-login --snaps=tuba \
  --acls package_access,package_release \
  SNAP_STORE_STABLE

Then set that in an environment variable named STORE_LOGIN

@GeopJr
Copy link
Owner

GeopJr commented Jun 9, 2024

I'll do so when I get on my snap environment! Thanks!

I have one more question though, if it compiles with -Ddevel=true, how do I make 'stable' builds from here? If I promote the edge one, it will be treated as devel and the action is not aware of repo releases. That's one of the reasons I split it into devel snap config and release snap config in a different repo.

@soumyaDghosh
Copy link
Contributor Author

I'll do so when I get on my snap environment! Thanks!

I have one more question though, if it compiles with -Ddevel=true, how do I make 'stable' builds from here? If I promote the edge one, it will be treated as devel and the action is not aware of repo releases. That's one of the reasons I split it into devel snap config and release snap config in a different repo.

Okay, so even more conditioning! Ummmm... For now I removed the devel using sed, but I think better you could do is replicate this in the snap manifests repo. And remove things from here which you don't need anymore.

@GeopJr
Copy link
Owner

GeopJr commented Jun 9, 2024

Here's an idea: How about I unlink the tuba-snap repo from the snapcraft runners and we instead add an action there with (workflow_dispatch so I can trigger it manually) to build and publish snaps?

That way, the action on this repo can stay as devel and the action on tuba-snap will always be release only

@GeopJr
Copy link
Owner

GeopJr commented Jun 18, 2024

Merging, thanks!

I don't know if/when I'll set up action publishing on the tuba-snap repo.

@GeopJr GeopJr merged commit 79d7dfd into GeopJr:main Jun 18, 2024
5 checks passed
@soumyaDghosh
Copy link
Contributor Author

Hi gnome+core24 now on stable

@GeopJr
Copy link
Owner

GeopJr commented Jun 27, 2024

Thanks for letting me know!

Can I drop SNAPCRAFT_ENABLE_EXPERIMENTAL_EXTENSIONS?

@soumyaDghosh
Copy link
Contributor Author

No Sorry, my bad, not yet. It's not yet stable. I hope in the next release of snapcraft, it'll be. And yes, you can drop it once stable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants