Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnome: add gpu-2404 integration #4744

Merged
merged 9 commits into from
Jun 13, 2024
Merged

gnome: add gpu-2404 integration #4744

merged 9 commits into from
Jun 13, 2024

Conversation

Saviq
Copy link
Contributor

@Saviq Saviq commented Apr 18, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

snapcraft/extensions/gnome.py Outdated Show resolved Hide resolved
@Saviq Saviq force-pushed the gnome-gpu-2404 branch 3 times, most recently from 302fece to c89ced2 Compare April 25, 2024 11:39
@mr-cal
Copy link
Collaborator

mr-cal commented Apr 26, 2024

FYI the core24 spread tests will be able to run after #4761 lands

Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code and the tests look good to me. What have you been building to test this? I'd like to build some core24 snaps on this branch

@Saviq
Copy link
Contributor Author

Saviq commented Apr 26, 2024

The code and the tests look good to me. What have you been building to test this? I'd like to build some core24 snaps on this branch

https://github.com/ubuntu/gnome-2048 with a s/base: core22/base: core24/ should do. Since I've no access to the relevant snaps, you'll need to build a gnome-46-2404 yourself from this branch to verify all this works:

ubuntu/gnome-sdk#203

@Saviq
Copy link
Contributor Author

Saviq commented Apr 26, 2024

@mr-cal here's a working expanded snapcraft.yaml, you can compare it to that on your side:

https://paste.ubuntu.com/p/RpMRnwbvfz/

And the tweaked snap:

ubuntu/gnome-2048@stable...Saviq:gnome-2048:core24

@Saviq
Copy link
Contributor Author

Saviq commented May 29, 2024

@mr-cal hey, anything missing here from your PoV?

@mr-cal
Copy link
Collaborator

mr-cal commented May 30, 2024

@mr-cal hey, anything missing here from your PoV?

@Saviq, sorry this has been stuck on my todo list. I'll test and review it tomorrow.

Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the long delay in reviewing this. It looks good and I built some gnome snaps - it works well!

@mr-cal mr-cal requested a review from cmatsuoka May 31, 2024 19:45
Copy link
Contributor

@cmatsuoka cmatsuoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We could do something later to avoid parsing the yaml by hand.

Has @kenvandine verified this?

@kenvandine
Copy link
Contributor

Looks good to me. We could do something later to avoid parsing the yaml by hand.

Has @kenvandine verified this?

I think we need @seb128 to verify, his team owns the SDK snap.

@sergiusens
Copy link
Collaborator

@mr-cal leaving this one to you!

Copy link
Contributor

@seb128 seb128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it also looks fine to me!

@mr-cal
Copy link
Collaborator

mr-cal commented Jun 13, 2024

Thanks for the approvals everyone, I'll land this now that canonical/snapcraft-desktop-integration#26 (comment) has been merged

@mr-cal mr-cal merged commit 6c56751 into canonical:main Jun 13, 2024
10 checks passed
@Saviq Saviq deleted the gnome-gpu-2404 branch June 13, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants