-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gnome: add gpu-2404 integration #4744
Conversation
302fece
to
c89ced2
Compare
- add explicit `-2404` to the content target. - drop `X11/locale` layout, now served through `XLOCALEDIR`
FYI the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code and the tests look good to me. What have you been building to test this? I'd like to build some core24 snaps on this branch
https://github.com/ubuntu/gnome-2048 with a |
@mr-cal here's a working expanded https://paste.ubuntu.com/p/RpMRnwbvfz/ And the tweaked snap: |
@mr-cal hey, anything missing here from your PoV? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the long delay in reviewing this. It looks good and I built some gnome snaps - it works well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. We could do something later to avoid parsing the yaml by hand.
Has @kenvandine verified this?
I think we need @seb128 to verify, his team owns the SDK snap. |
@mr-cal leaving this one to you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it also looks fine to me!
Thanks for the approvals everyone, I'll land this now that canonical/snapcraft-desktop-integration#26 (comment) has been merged |
tox run -m lint
?tox run -e test-py310
? (supported versions:py39
,py310
,py311
,py312
)