Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snap: rely on gpu-2404 providers for GPU userspace #203

Merged
merged 2 commits into from
May 29, 2024

Conversation

Saviq
Copy link

@Saviq Saviq commented Apr 19, 2024

@Saviq Saviq changed the title Gnome 46 2404 gpu interface snap: rely on gpu-2404 providers for GPU userspace Apr 25, 2024
Copy link
Contributor

@sergio-costas sergio-costas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. Moving these elements into its own snap seems sensible.

@Saviq Saviq force-pushed the gnome-46-2404-gpu-interface branch 2 times, most recently from 77f0e90 to 01035e1 Compare April 26, 2024 14:31
@Saviq Saviq force-pushed the gnome-46-2404-gpu-interface branch 2 times, most recently from 45823cd to c9edc67 Compare May 6, 2024 16:18
@Saviq
Copy link
Author

Saviq commented May 6, 2024

Dropped the temporary commit, desktop wrappers merged now.

@Saviq Saviq force-pushed the gnome-46-2404-gpu-interface branch from c9edc67 to 0d714f2 Compare May 9, 2024 13:59
@kenvandine kenvandine requested a review from seb128 May 11, 2024 06:10
@Saviq
Copy link
Author

Saviq commented May 29, 2024

Hey, anything missing here?

Copy link
Contributor

@seb128 seb128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me and we probably want to land that before we start moving you snaps to core24 so let's merge now and see how it's working!

@seb128 seb128 merged commit aed0db3 into ubuntu:gnome-46-2404 May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants