[PBE-4800] Support Voice Recording in Compose #5404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/attachments/StreamAttachmentFactories.kt # stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/attachments/factory/AudioRecordAttachmentFactory.kt
skydoves
reviewed
Sep 18, 2024
...getstream/chat/android/compose/ui/attachments/content/AudioRecordAttachmentPreviewContent.kt
Outdated
Show resolved
Hide resolved
...ava/io/getstream/chat/android/compose/ui/attachments/content/AudioRecordAttachmentContent.kt
Outdated
Show resolved
Hide resolved
...e/src/main/java/io/getstream/chat/android/compose/viewmodel/messages/AudioPlayerViewModel.kt
Outdated
Show resolved
Hide resolved
...in/kotlin/io/getstream/chat/android/ui/common/feature/messages/list/AudioPlayerController.kt
Outdated
Show resolved
Hide resolved
.../src/main/kotlin/io/getstream/chat/android/ui/common/state/messages/list/AudioPlayerState.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Overall looks great, great job. I left some trivial comments about docs.
I also left a comment regarding the parameters count at two places. This should not affect the functionality, but I think will at least not increase the complexity of the MessageComposer. I think we should start avoiding the long parameter lists in any possible way :)
...ava/io/getstream/chat/android/compose/ui/attachments/content/AudioRecordAttachmentContent.kt
Show resolved
Hide resolved
...ava/io/getstream/chat/android/compose/ui/attachments/content/AudioRecordAttachmentContent.kt
Outdated
Show resolved
Hide resolved
...getstream/chat/android/compose/ui/attachments/content/AudioRecordAttachmentPreviewContent.kt
Show resolved
Hide resolved
...ompose/src/main/java/io/getstream/chat/android/compose/ui/components/audio/WaveformSlider.kt
Outdated
Show resolved
Hide resolved
...pose/src/main/java/io/getstream/chat/android/compose/ui/messages/composer/MessageComposer.kt
Outdated
Show resolved
Hide resolved
...pose/src/main/java/io/getstream/chat/android/compose/ui/messages/composer/MessageComposer.kt
Outdated
Show resolved
Hide resolved
...chat/android/compose/ui/messages/composer/internal/DefaultMessageComposerRecordingContent.kt
Outdated
Show resolved
Hide resolved
aleksandar-apostolov
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Closes:
🎨 UI Changes
Screen_recording_20240916_211127.webm
☑️Contributor Checklist
General
developbranchCode & documentation
☑️Reviewer Checklist
🎉 GIF
Please provide a suitable gif that describes your work on this pull request