Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBE-4800] fix found voice recording issues #5412

Merged
merged 29 commits into from
Sep 25, 2024

Conversation

kanat
Copy link
Collaborator

@kanat kanat commented Sep 19, 2024

🎯 Goal

Related PR:

Found issues:

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@kanat kanat changed the base branch from main to develop September 19, 2024 22:40
@kanat kanat marked this pull request as ready for review September 19, 2024 23:12
@kanat kanat requested a review from a team as a code owner September 19, 2024 23:12
Copy link
Collaborator

@testableapple testableapple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! 🙂

@aleksandar-apostolov aleksandar-apostolov merged commit 0794b28 into develop Sep 25, 2024
7 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the fix/voice-recording-compose branch September 25, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants