Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master update post Beta 2 release #3808

Merged
merged 56 commits into from
Jul 4, 2024
Merged

Master update post Beta 2 release #3808

merged 56 commits into from
Jul 4, 2024

Conversation

Maheshkale447
Copy link
Contributor

@Maheshkale447 Maheshkale447 commented Jul 4, 2024

Thank you for your contribution.
Before submitting this PR, please make sure:

  • PR description and commit message should describe the changes done in this PR
  • Verify the PR is pointing to correct branch i.e. Release or Beta branch if the code fix is for specific release , else point it to master
  • Latest Code from master or specific release branch is merged to your branch
  • No unwanted\commented\junk code is included
  • No new warning upon build solution
  • Code Summary\Comments are added to my code which explains what my code is doing
  • Existing unit test cases are passed
  • New Unit tests are added for your development
  • Sanity Tests are successfully executed for New and Existing Functionality
  • Verify that changes are compatible with all relevant browsers and platforms.
  • After creating pull request there should not be any conflicts
  • Resolve all Codacy comments
  • Builds and checks are passed before PR is sent for review
  • Resolve code review comments
  • Update the Help Library document to match any feature changes

Summary by CodeRabbit

  • New Features

    • Introduced new configuration file LUTConfig for repository settings, parallel builds, and test configurations.
  • Bug Fixes

    • Enhanced error handling and logic flow in ExecuteDataToJira to better manage conditions and error messages.
    • Fixed a UI issue in ValidationDBPage by adjusting margins and applying styles to TextBox.
  • Improvements

    • Enhanced the merging logic for properties and locators in PomDeltaUtils.
    • Updated methods to handle file operations more efficiently in AddNewDataSourcePage.
    • Modified window dimensions for better interface in MobileDriverWindow.
    • Updated dictionary structure in RunSetConfig to store lists of agents.
  • Refactor

    • Refactored element filtering logic in POMExecutionUtils to improve code modularity.
    • Improved encapsulation and clarity in POMLocatorParser.
  • Style

    • Adjusted .editorconfig to ensure preservation of single-line blocks in C# code.
  • Tests

    • Moved DevelopmentTimeForBFTest to a new namespace for better organization.
  • Chores

    • Updated version numbers in GingerCoreCommon.csproj.
    • Added .editorconfig to GingerCoreCommonTest.csproj for consistency.

IamRanjeetSingh and others added 30 commits June 24, 2024 18:30
Also refactored the code for serializer wherever applicable
…ngToZeroOnReload

Bug fix/dev time resetting to zero on reload
[Defect Id: 40342]removed margin and added borders for DB action
…rPlaywrightSupportExistingPOM

Feature - 39520 - Tests For Playwright Support Existing POM
Fixed serializer so Empty Guid and Zero timespan won't get serialized
2- fixing category related bugs
3- added check for mobile driver to validate the session is still active before taking screen shoot
1- fixed missing POM elements category setup
…ppedIssue

D39589_ runner gets skipped Fixed
amanpras and others added 26 commits June 28, 2024 17:12
…close the last opened tab manually. If we run any failing action, it is not able to take the screenshot.

RC: When we close the tab manually, our code doesn't get notified and it still tries to take screenshot from the already closed tab.
Fix: Add Close event listener to Playwright Page and handle manual tab close.
…essageJIRA

Error Message fix for Exporting result for JIRA, on ALM test set leve…
…otNotAvailableWhenTabClosedManually

BugFix - 39592 - Screenshot Not Available When Tab Closed Manually
POM Learning: Removed unwanted chars and space while creation optiona…
2- fixing bugs with merging 2 POM elements from same Category
…yCounterStop

Fix - Activity Dev Time counter Stop on switching the business flow
1- fixing bug in taking screen shot for for Appium Web session
@Maheshkale447 Maheshkale447 merged commit d364458 into master Jul 4, 2024
1 check passed
Copy link
Contributor

coderabbitai bot commented Jul 4, 2024

Warning

Rate limit exceeded

@Maheshkale447 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 13 minutes and 13 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between e92b6f1 and 64adc82.

Walkthrough

The changes span updates to GitHub workflows, new configuration files, adjustments to UI layouts, enhancements to data sources and timers, and modifications to various functionalities across multiple files. The updates aim to improve performance, extend functionalities, streamline configurations, and refine UI components.

Changes

Files/Directories Change Summaries
.github/workflows/CD.yml Updated the version field default value from '1' to '2'.
Ginger/Ginger.lutconfig Introduced a new configuration file for settings like repository location, parallel builds, and more.
Ginger/Ginger/Actions/.../ValidationDBPage.xaml Adjusted UI Margin and applied a style to a TextBox.
Ginger/Ginger/ApplicationModelsLib/.../PomAllElementsPage.* Added SetLocatorsAndPropertiesCategory method calls.
Ginger/Ginger/ApplicationModelsLib/.../PomElementsPage.cs Improved merge messaging to include element names.
Ginger/Ginger/AutomatePageLib/.../WindowExplorerPage.cs Added category setting to element information updates.
Ginger/Ginger/DataSource/AddNewDataSourcePage.cs Enhanced initialization and file operations.
Ginger/Ginger/Drivers/.../MobileDriverWindow.xaml Adjusted window dimensions.
Ginger/Ginger/SolutionWindows/.../BusinessFlowTreeItem.cs Added checks to stop activity timers before stopping business flow timer.
Ginger/Ginger/UserControlsLib/LiveSpyHandler.cs Added using directive and method call to update locators and properties categories.
GingerCoreCommon/.editorconfig Set configuration to preserve single-line blocks in C#.
GingerCoreCommon/GingerCoreCommon.csproj Updated version numbers.
GingerCoreCommon/Repository/BusinessFlowLib/Activity.cs Added a setter for DevelopmentTime with update checks.
GingerCoreCommon/Repository/BusinessFlowLib/BusinessFlow.cs Updated DevelopmentTime setter for value change checks.
GingerCoreCommon/Repository/NewRepositorySerializer.cs Enhanced serialization and deserialization logic and added error handling.
GingerCoreCommon/Run/RunSetConfig.cs Modified dictionary to store lists of IAgent instances.
GingerCoreCommonTest/DevelopmentTimeTest/... Moved class to a different namespace.
GingerCoreCommonTest/GingerCoreCommonTest.csproj Included .editorconfig as a linked file.
GingerCoreNET/ALMLib/JIRA/Bll/JiraExportManager.cs Improved error handling and logical checks for JIRA export.
GingerCoreNET/Application Models/Delta/.../PomDeltaUtils.cs Enhanced merging conditions for properties and locators.
GingerCoreNET/Application Models/Execution/.../POMExecutionUtils.cs Refactored filtering logic to improve modularity.
GingerCoreNET/Drivers/CoreDrivers/Mobile/.../GenericAppiumDriver.cs Added checks and refactored element highlighting and screenshot methods.
GingerCoreNET/Drivers/CoreDrivers/Web/ActionHandlers/... Added imports and improved element locator handling.
GingerCoreNET/Drivers/CoreDrivers/Web/.../POMElementLocator.cs Added comments, enhanced logic for locating elements based on configuration.
GingerCoreNET/Drivers/CoreDrivers/Web/.../POMLocatorParser.cs Improved encapsulation and initialized properties for POM handling.
GingerCoreNET/Drivers/CoreDrivers/Web/.../PlaywrightBrowserTab.cs Added method to remove event handlers and improved tab closure logic.

Poem

In the land of code where changes bloom,
A rabbit hops and clears the gloom 🌸,
From heights to widths and merging tales,
Improvements ride on digital sails.
With versions new and setups bright,
Our bunny sings through day and night,
Hooray for code, so newly spun,
Each byte a dance, each change, such fun! 🐰✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants