-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 2.0.0 #562
Version 2.0.0 #562
Conversation
I like LaTeX but I definitely think it's a "nice-to-have". On the GitBook website it'll be OK, but the dependencies it pulls in on Windows or Linux workstations are huge - on the order of a gigabyte minimum. That said, every machine I use has those already (plus Pandoc and its dependencies!) so it won't impact me if you do support LaTeX. |
@znmeb LaTeX will not need to be a dependency of GitBook, it will be needed only if the author is using latex files. Supporting LaTeX is not the priority of this release, but it'll now be possible. |
I made some inline corrections for the German texts (f121635). |
@SamyPesse no 🍻 today anymore 😉 💤 |
@SamyPesse 👍 (a little bit impressed that you do a complete rewrite within one week) |
Thanks, I know perfectly the gitbook structure, so it's easy to rebuild it and make it better. Is "Einführung" right for "Introduction" (99d9d49#diff-d20357f2347472b13b032ff4c59f77e7R8) ? |
@SamyPesse It would be great, to avoid having to wrap chapters with The ideal behaviour would be that if the expression to display (in the ``{{ ... }} The other option would be to skip them inside What do you think ? |
@AaronO I think this is a bad idea, because:
I think who are focus on this, because you just commit a small change on the documentation and you are focusing on your tiny issue, without understanding the bad consequence on bringing that kind of complexity into the simple generation pipeline. Another solution can be a configuration in the |
@SamyPesse I disagree, It's used in "formatting" url examples for API docs etc ... : http://help.gitbook.com/build/push.html#git-url.
Books on Go programming, Django programming (web programming in general), api docs etc ... will be effected by this suggesting that they patch their pages with And over that, that's the current behaviour right now : https://github.com/GitbookIO/gitbook/blob/master/lib/parse/include.js#L8. This really shouldn't be complicated to fix and I think it makes it more obvious to see typos if the person is using variables. It doesn't at all have to be a big change in the pipeline, it should be two or three lines with no conditional, that's not going to turn GitBook into a conditional "mess" ... The way I see it, there's only two possible reasons a person's
In both those cases displaying something blank is in my opinion useless. I'm more likely to notice an error of a misspelled variable if it still displays What is there to lose and what's the cost ? Disabling templating is extreme and not needed when this "fix" is both useful, simple and compatible with what's already out there. |
With your solution, books about Django, Nunjucks,etc will still have issue, your solution will change nothing to the processing of You believe your solution is easy, but you'll have to handle correctly the expression parsing, for example: You are considering an hack to solve an UX problem (that you're the only one to encounter yet). I think it's pre-matured. The version Why not wait to get feedback from the authors about this? See how much users are having issue with the But instead of talking about this, you're sure of your solution, that it's clean, then just do a Pull-Request and we'll talk on it. |
@AaronO Would disabling template parsing for book content by default and having to explicitly enable it solve your issue? I can imagine that people that make use of the templating syntax refer to the documentation beforehand (other than people using |
@SamyPesse Input versions should be validated:
|
@AaronO this is related to gitbook-cli, post an issue there. |
[i18n] - fa: Persian/Farsi
Sort glossary and fix #634
Version 2.0.0
How to test it?
Uninstall GitBook 1.x.x:
Install GitBook CLI:
You can now build a book using the version 2.0.0 (this will download the latest alpha version of GitBook):
Changes:
gitbook
from book.json to define the version of gitbook to use{% include "./test.md" %}
("Include" extenal content #226){% include "git+https://github.com/GitBookIO/markdown.git/test.md#sha" %}
or using variables{% include book.markdownBook+"/test.md#sha" %}
language
parameter or detect for multilingual books.md
,.mdown
,.markdown
) (Read .Rmd files too? #307 and MarkDown has servel suffix,such as .md、.mdown、.markdown. Are they supported? #436)README.html
=>/
(really/index.html
)page:before
hooksegmentation fault: 11
, maybe due to asciidoc.git
and.svn
when cleaning output folder (Gitbook deletes the output directory #273)Plugins Compatibility
Related: