Misc cleanup #254

m4gr3d · 2025-01-28T02:36:30Z

Misc cleanup based on feedback from #238 (comment):

Move pico namespace constants to class constants
Move meta namespace constants to class constants
Set the update_visibility field for the vendor toggle option to true to allow overriding the export options when their corresponding vendor is toggled on/off
Add an helper method for generating the manifest entry for the GodotPanelApp from [DRAFT] Support making hybrid apps for Pico headsets #246 (decoupled from the PR to unblock prototyping on [DRAFT] Add support for the Android XR OpenXR vendor #238)

dsnopek

Thanks! LGTM :-)

Manual pick from GodotVR#254

m4gr3d added the enhancement New feature or request label Jan 28, 2025

m4gr3d added this to the 4.x milestone Jan 28, 2025

m4gr3d requested review from dsnopek, BastiaanOlij and devloglogan January 28, 2025 02:36

Misc cleanup based on feedback from GodotVR#238 (comment)

afb693c

m4gr3d force-pushed the misc_cleanup branch from 134ab90 to afb693c Compare January 28, 2025 02:44

dsnopek approved these changes Jan 29, 2025

View reviewed changes

m4gr3d merged commit dabe6c7 into GodotVR:master Feb 2, 2025
11 checks passed

m4gr3d deleted the misc_cleanup branch February 2, 2025 19:10

m4gr3d added a commit to m4gr3d/godot_openxr_vendors that referenced this pull request Feb 7, 2025

Fix the issue preventing overridden vendor options from being updated

aa4d16e

Manual pick from GodotVR#254

m4gr3d mentioned this pull request Feb 7, 2025

Fix the issue preventing overridden vendor options from being updated #262

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Misc cleanup #254

Misc cleanup #254

m4gr3d commented Jan 28, 2025 •

edited

Loading

dsnopek left a comment

Misc cleanup #254

Misc cleanup #254

Conversation

m4gr3d commented Jan 28, 2025 • edited Loading

dsnopek left a comment

Choose a reason for hiding this comment

m4gr3d commented Jan 28, 2025 •

edited

Loading