Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the issue preventing overridden vendor options from being updated #262

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Fix the issue preventing overridden vendor options from being updated #262

merged 1 commit into from
Feb 7, 2025

Conversation

m4gr3d
Copy link
Collaborator

@m4gr3d m4gr3d commented Feb 7, 2025 •
edited
Loading

Manual pick from #254

Fixes #256

@m4gr3d m4gr3d added the bug Something isn't working label Feb 7, 2025
@m4gr3d m4gr3d added this to the 3.x milestone Feb 7, 2025
@m4gr3d
Copy link
Collaborator Author

m4gr3d commented Feb 7, 2025

Once this is merged, let's do and push a 3.1.2 release

BastiaanOlij
BastiaanOlij approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it worked!

image

dsnopek
dsnopek approved these changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes it in my testing too!

I'll start making the release in a moment.

@dsnopek dsnopek merged commit 2dd0bf6 into GodotVR:3.x Feb 7, 2025
10 checks passed
@m4gr3d m4gr3d deleted the fix_update_visibility_for_vendor_options branch February 7, 2025 16:57
@dsnopek dsnopek mentioned this pull request Feb 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsnopek dsnopek dsnopek approved these changes

@BastiaanOlij BastiaanOlij BastiaanOlij approved these changes

@devloglogan devloglogan Awaiting requested review from devloglogan

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
3.x
Development

Successfully merging this pull request may close these issues.
3 participants
@m4gr3d @dsnopek @BastiaanOlij