Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade trace_engine and drop manually written types #15810

Merged
merged 4 commits into from
Feb 15, 2024

Apply suggestions from code review

f8b333c
Select commit
Loading
Failed to load commit list.
Merged

deps: upgrade trace_engine and drop manually written types #15810

Apply suggestions from code review
f8b333c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Feb 15, 2024 in 1s

87.27% of diff hit (target 96.98%)

View this Pull Request on Codecov

87.27% of diff hit (target 96.98%)

Annotations

Check warning on line 168 in core/computed/metrics/cumulative-layout-shift.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/computed/metrics/cumulative-layout-shift.js#L167-L168

Added lines #L167 - L168 were not covered by tests

Check warning on line 72 in core/computed/trace-engine-result.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/computed/trace-engine-result.js#L71-L72

Added lines #L71 - L72 were not covered by tests

Check warning on line 99 in core/gather/gatherers/root-causes.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/gather/gatherers/root-causes.js#L97-L99

Added lines #L97 - L99 were not covered by tests