core: remove budgets #15950
Merged
core: remove budgets #15950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
reviewed
Apr 16, 2024
| @@ -64,20 +64,6 @@ describe('Performance: Resource summary audit', () => { | |||
| expect(thirdParty.transferSize).toBe(145); | |||
| expect(thirdParty.requestCount).toBe(3); | |||
| }); | |||
|
|
|||
| it('uses firstPartyHostnames if provided', async () => { | |||
There was a problem hiding this comment.
FWIW this does seem like a feature we are losing with this PR. That being said, it's only used in this one hidden audit and not anywhere else so I still think it's fine.
build/test/page-functions-test-case-computeBenchmarkIndex-out.js.map
Outdated
Show resolved
Hide resolved
adamraine
approved these changes
Apr 17, 2024
| @@ -13,37 +13,6 @@ const budgetedConfig = { | |||
| extends: 'lighthouse:default', | |||
| settings: { | |||
| throttlingMethod: 'devtools', | |||
| budgets: [{ | |||
There was a problem hiding this comment.
nit: this is called budgetedConfig here and in update-report-fixtures.js. Could we just call it sampleConfig?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #15203