core: remove budgets

build/build-sample-reports.js

@@ -119,7 +119,7 @@ function addPluginCategory(sampleLhr) {
 }
 
 /**
- * Drops the LHR to only one, solo category (performance), and removes budgets.
+ * Drops the LHR to only one, solo category (performance).
  * @param {LH.Result} sampleLhr
  */
 function tweakLhrForPsi(sampleLhr) {
@@ -128,11 +128,6 @@ function tweakLhrForPsi(sampleLhr) {
   clone.categories = {
     'performance': clone.categories.performance,
   };
-  // no budgets in PSI
-  delete clone.audits['performance-budget'];
-  clone.categories.performance.auditRefs = clone.categories.performance.auditRefs.filter(audit => {
-    return !audit.id.endsWith('-budget');
-  });
   return clone;
 }
 

cli/bin.js

@@ -79,13 +79,6 @@ async function begin() {
     config = (await import(`../core/config/${cliFlags.preset}-config.js`)).default;
   }
 
-  if (cliFlags.budgetPath) {
-    cliFlags.budgetPath = path.resolve(process.cwd(), cliFlags.budgetPath);
-    /** @type {Array<LH.Budget>} */
-    const parsedBudget = JSON.parse(fs.readFileSync(cliFlags.budgetPath, 'utf8'));
-    cliFlags.budgets = parsedBudget;
-  }
-
   // set logging preferences
   cliFlags.logLevel = 'info';
   if (cliFlags.verbose) {

cli/cli-flags.js

@@ -196,10 +196,6 @@ function getYargsParser(manualArgv) {
         coerce: splitCommaSeparatedValues,
         describe: 'Run everything except these audits',
       },
-      'budget-path': {
-        type: 'string',
-        describe: 'The path to the budget.json file for LightWallet.',
-      },
       'disable-full-page-screenshot': {
         type: 'boolean',
         describe: 'Disables collection of the full page screenshot, which can be quite large',
@@ -213,7 +209,7 @@ function getYargsParser(manualArgv) {
       'save-assets', 'list-all-audits', 'list-locales', 'list-trace-categories', 'additional-trace-categories',
       'config-path', 'preset', 'chrome-flags', 'port', 'hostname', 'form-factor', 'screenEmulation', 'emulatedUserAgent',
       'max-wait-for-load', 'enable-error-reporting', 'gather-mode', 'audit-mode',
-      'only-audits', 'only-categories', 'skip-audits', 'budget-path', 'disable-full-page-screenshot', 'ignore-status-code',
+      'only-audits', 'only-categories', 'skip-audits', 'disable-full-page-screenshot', 'ignore-status-code',
     ], 'Configuration:')
 
     // Output

cli/test/cli/__snapshots__/cli-flags-test.js.snap

@@ -383,10 +383,6 @@ Object {
   "_": Array [
     "http://www.example.com",
   ],
-  "budget-path": "path/to/my/budget-from-config.json",
-  "budgetPath": "path/to/my/budget-from-config.json",
-  "budgets-path": "path/to/my/budget-from-command-line.json",
-  "budgetsPath": "path/to/my/budget-from-command-line.json",
   "channel": "cli",
   "chrome-flags": "--window-size 800,600",
   "chrome-ignore-default-flags": false,

cli/test/cli/bin-test.js

@@ -4,7 +4,6 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-import fs from 'fs';
 import {pathToFileURL} from 'url';
 
 import * as td from 'testdouble';
@@ -114,17 +113,6 @@ describe('CLI bin', function() {
     });
   });
 
-  describe('budget', () => {
-    it('should load the config from the path', async () => {
-      const budgetPath = `${LH_ROOT}/core/test/fixtures/simple-budget.json`;
-      cliFlags = {...cliFlags, budgetPath};
-      const budgetFile = JSON.parse(fs.readFileSync(budgetPath, 'utf-8'));
-      await bin.begin();
-
-      expect(getRunLighthouseArgs()[1].budgets).toEqual(budgetFile);
-    });
-  });
-
   describe('logging', () => {
     it('should have info by default', async () => {
       await bin.begin();

cli/test/cli/cli-flags-test.js

@@ -56,11 +56,9 @@ describe('CLI flags', function() {
     const flags = getFlags([
       'http://www.example.com',
       `--cli-flags-path="${LH_ROOT}/cli/test/fixtures/cli-flags-path.json"`,
-      '--budgets-path=path/to/my/budget-from-command-line.json', // this should override the config value
     ].join(' '));
 
     expect(flags).toMatchObject({
-      budgetsPath: 'path/to/my/budget-from-command-line.json',
       onlyCategories: ['performance', 'seo'],
       chromeFlags: '--window-size 800,600',
       extraHeaders: {'X-Men': 'wolverine'},
@@ -73,17 +71,6 @@ describe('CLI flags', function() {
     snapshot(flags);
   });
 
-  it('settings are accepted from a file path (inlined budgets)', () => {
-    const flags = getFlags([
-      'http://www.example.com',
-      // eslint-disable-next-line max-len
-      `--cli-flags-path="${LH_ROOT}/cli/test/fixtures/cli-flags-path-inline-budgets.json"`,
-    ].join(' '));
-
-    expect(flags.budgets).toMatchObject([{'anything': 'works'}]);
-    snapshot(flags);
-  });
-
   it('array values support csv when appropriate', () => {
     const flags = getFlags([
       'http://www.example.com',

cli/test/fixtures/cli-flags-path.json

@@ -1,5 +1,4 @@
 {
-  "budgetPath": "path/to/my/budget-from-config.json",
   "onlyCategories": ["performance", "seo"],
   "chromeFlags": "--window-size 800,600",
   "extraHeaders": {"X-Men": "wolverine"},

cli/test/smokehouse/core-tests.js

@@ -34,7 +34,6 @@ import metricsTrickyTti from './test-definitions/metrics-tricky-tti.js';
 import metricsTrickyTtiLateFcp from './test-definitions/metrics-tricky-tti-late-fcp.js';
 import oopifRequests from './test-definitions/oopif-requests.js';
 import oopifScripts from './test-definitions/oopif-scripts.js';
-import perfBudgets from './test-definitions/perf-budgets.js';
 import perfDebug from './test-definitions/perf-debug.js';
 import perfDiagnosticsAnimations from './test-definitions/perf-diagnostics-animations.js';
 import perfDiagnosticsThirdParty from './test-definitions/perf-diagnostics-third-party.js';
@@ -92,7 +91,6 @@ const smokeTests = [
   metricsTrickyTtiLateFcp,
   oopifRequests,
   oopifScripts,
-  perfBudgets,
   perfDebug,
   perfDiagnosticsAnimations,
   perfDiagnosticsThirdParty,

cli/test/smokehouse/test-definitions/perf-fonts.js

@@ -16,39 +16,6 @@ const config = {
     // BF cache will request the page again, initiating additional network requests.
     // Disable the audit so we only detect requests from the normal page load.
     skipAudits: ['bf-cache'],
-
-    // A mixture of under, over, and meeting budget to exercise all paths.
-    budgets: [{
-      path: '/',
-      resourceCounts: [
-        {resourceType: 'total', budget: 8},
-        {resourceType: 'stylesheet', budget: 1}, // meets budget
-        {resourceType: 'image', budget: 1},
-        {resourceType: 'media', budget: 0},
-        {resourceType: 'font', budget: 2}, // meets budget
-        {resourceType: 'script', budget: 1},
-        {resourceType: 'document', budget: 0},
-        {resourceType: 'other', budget: 1},
-        {resourceType: 'third-party', budget: 0},
-      ],
-      resourceSizes: [
-        {resourceType: 'total', budget: 100},
-        {resourceType: 'stylesheet', budget: 0},
-        {resourceType: 'image', budget: 30}, // meets budget
-        {resourceType: 'media', budget: 0},
-        {resourceType: 'font', budget: 75},
-        {resourceType: 'script', budget: 30},
-        {resourceType: 'document', budget: 1},
-        {resourceType: 'other', budget: 2}, // meets budget
-        {resourceType: 'third-party', budget: 0},
-      ],
-      timings: [
-        {metric: 'first-contentful-paint', budget: 2000},
-        {metric: 'interactive', budget: 2000},
-        {metric: 'first-meaningful-paint', budget: 2000},
-        {metric: 'max-potential-fid', budget: 2000},
-      ],
-    }],
   },
 };
 

cli/test/smokehouse/test-definitions/perf-frame-metrics.js

@@ -16,39 +16,6 @@ const config = {
     // BF cache will request the page again, initiating additional network requests.
     // Disable the audit so we only detect requests from the normal page load.
     skipAudits: ['bf-cache'],
-
-    // A mixture of under, over, and meeting budget to exercise all paths.
-    budgets: [{
-      path: '/',
-      resourceCounts: [
-        {resourceType: 'total', budget: 8},
-        {resourceType: 'stylesheet', budget: 1}, // meets budget
-        {resourceType: 'image', budget: 1},
-        {resourceType: 'media', budget: 0},
-        {resourceType: 'font', budget: 2}, // meets budget
-        {resourceType: 'script', budget: 1},
-        {resourceType: 'document', budget: 0},
-        {resourceType: 'other', budget: 1},
-        {resourceType: 'third-party', budget: 0},
-      ],
-      resourceSizes: [
-        {resourceType: 'total', budget: 100},
-        {resourceType: 'stylesheet', budget: 0},
-        {resourceType: 'image', budget: 30}, // meets budget
-        {resourceType: 'media', budget: 0},
-        {resourceType: 'font', budget: 75},
-        {resourceType: 'script', budget: 30},
-        {resourceType: 'document', budget: 1},
-        {resourceType: 'other', budget: 2}, // meets budget
-        {resourceType: 'third-party', budget: 0},
-      ],
-      timings: [
-        {metric: 'first-contentful-paint', budget: 2000},
-        {metric: 'interactive', budget: 2000},
-        {metric: 'first-meaningful-paint', budget: 2000},
-        {metric: 'max-potential-fid', budget: 2000},
-      ],
-    }],
   },
 };