report: render LH-only diagnostics alongside insights #16332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
commented
Feb 13, 2025
| @@ -76,4 +76,6 @@ export interface Result { | |||
| }; | |||
| /** A number indicating how much guidance Lighthouse provides to solve the problem in this audit on a 1-3 scale. Higher means more guidance. */ | |||
| guidanceLevel?: number; | |||
| /** A list of audit ids that this audit replaces. Used to ensure the report does not render the audits in this list at the same time as the audit which contains the list. */ | |||
| replacesAudits?: string[]; | |||
There was a problem hiding this comment.
This was proposed by go/lh-rpp-roadmap to document the replaced audits for JSON users.
Also seems like a good way to define which old audits need to stick around in the new insight view. We could organize audits into new groups, but since this is an experimental UI phase I would rather not mess with the groups if possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/393415599
Some LH perf diagnostics (e.g. bfcache) will continue to live as LH-only audits even after we reconcile most performance audits with RPP. We will need to render these LH-only audits alongside the new RPP insights.
This PR introduces a
replacesAuditsstructure to the Audit meta & the LHR which defines the list of audits that have been replaced by RPP insights. As we introduce more insights, the # of replaced audits will grow. The # of non-replaced audits should eventually shrink to cover just the old audits we intend to keep in LH long-term.Sample: https://lighthouse-k6ds89i6b-googlechrome.vercel.app/sample-reports/english/