Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report: render LH-only diagnostics alongside insights #16332

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/audits/audit.js
Original file line number Diff line number Diff line change
Expand Up @@ -478,6 +478,7 @@ class Audit {

details: product.details,
guidanceLevel: audit.meta.guidanceLevel,
replacesAudits: audit.meta.replacesAudits,
};
}

Expand Down
1 change: 1 addition & 0 deletions core/audits/insights/cls-culprits-insight.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ class CLSCulpritsInsight extends Audit {
description: str_(UIStrings.description),
guidanceLevel: 3,
requiredArtifacts: ['traces', 'TraceElements'],
replacesAudits: ['layout-shifts', 'non-composited-animations', 'unsized-images'],
};
}

Expand Down
1 change: 1 addition & 0 deletions core/audits/insights/document-latency-insight.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ class DocumentLatencyInsight extends Audit {
description: str_(UIStrings.description),
guidanceLevel: 3,
requiredArtifacts: ['traces', 'TraceElements'],
replacesAudits: ['redirects', 'server-response-time', 'uses-text-compression'],
};
}

Expand Down
1 change: 1 addition & 0 deletions core/audits/insights/dom-size-insight.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ class DOMSizeInsight extends Audit {
description: str_(UIStrings.description),
guidanceLevel: 3,
requiredArtifacts: ['traces', 'TraceElements'],
replacesAudits: ['dom-size'],
};
}

Expand Down
1 change: 1 addition & 0 deletions core/audits/insights/font-display-insight.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ class FontDisplayInsight extends Audit {
description: str_(UIStrings.description),
guidanceLevel: 3,
requiredArtifacts: ['traces', 'TraceElements'],
replacesAudits: ['font-display'],
};
}

Expand Down
6 changes: 6 additions & 0 deletions core/audits/insights/image-delivery-insight.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,12 @@ class ImageDeliveryInsight extends Audit {
description: str_(UIStrings.description),
guidanceLevel: 3,
requiredArtifacts: ['traces', 'TraceElements'],
replacesAudits: [
'modern-image-formats',
'uses-optimized-images',
'efficient-animated-content',
'uses-responsive-images',
],
};
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ class InteractionToNextPaintInsight extends Audit {
description: str_(UIStrings.description),
guidanceLevel: 3,
requiredArtifacts: ['traces', 'TraceElements'],
replacesAudits: ['work-during-interaction'],
};
}

Expand Down
1 change: 1 addition & 0 deletions core/audits/insights/lcp-discovery-insight.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ class LCPDiscoveryInsight extends Audit {
description: str_(UIStrings.description),
guidanceLevel: 3,
requiredArtifacts: ['traces', 'TraceElements'],
replacesAudits: ['prioritize-lcp-image', 'lcp-lazy-loaded'],
};
}

Expand Down
1 change: 1 addition & 0 deletions core/audits/insights/lcp-phases-insight.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ class LCPPhasesInsight extends Audit {
description: str_(UIStrings.description),
guidanceLevel: 3,
requiredArtifacts: ['traces', 'TraceElements'],
replacesAudits: ['largest-contentful-paint-element'],
};
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ class LongCriticalNetworkTreeInsight extends Audit {
description: str_(UIStrings.description),
guidanceLevel: 3,
requiredArtifacts: ['traces', 'TraceElements'],
replacesAudits: ['critical-request-chains'],
};
}

Expand Down
1 change: 1 addition & 0 deletions core/audits/insights/render-blocking-insight.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ class RenderBlockingInsight extends Audit {
description: str_(UIStrings.description),
guidanceLevel: 3,
requiredArtifacts: ['traces', 'TraceElements'],
replacesAudits: ['render-blocking-resources'],
};
}

Expand Down
1 change: 1 addition & 0 deletions core/audits/insights/third-parties-insight.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ class ThirdPartiesInsight extends Audit {
description: str_(UIStrings.description),
guidanceLevel: 3,
requiredArtifacts: ['traces', 'TraceElements'],
replacesAudits: ['third-party-summary'],
};
}

Expand Down
1 change: 1 addition & 0 deletions core/audits/insights/viewport-insight.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ class ViewportInsight extends Audit {
description: str_(UIStrings.description),
guidanceLevel: 3,
requiredArtifacts: ['traces', 'TraceElements'],
replacesAudits: ['viewport'],
};
}

Expand Down
Loading
Loading