Set cache: 'reload' on precaching requests #2176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-Bot Size PluginChanged File Sizes
New FilesNo new files have been added. All File SizesView Table
Workbox Aggregate Size Plugin3.5KB gzip'ed (23% of limit) |
philipwalton
approved these changes
Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @philipwalton
Fixes #2146
This PR sets
cache: 'reload'as an alternative to using the__WB_REVISION=...URL query parameter on the outgoing network requests used to populate the precache.I also renamed some variables to clarify the distinction between
cacheKey&urlwithin theinstall()method.The underlying precache keys still use the
__WB_REVISION=...query parameters, as we continue to use those parameters as versioning metadata.There's a slight breaking change in the
updatedURLs¬UpdatedURLsvalues that are returned byinstall(): the previously would include__WB_REVISIONquery parameters, and now they won't. Since those return values are only used for logging/display purposes, this change is probably an improvement.