Use cache: default for precaching requests when it's safe to #2222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was revisiting the changes in #2176, and realized that one unintended consequence was that if the HTTP cache contained a valid entry for a URL that could be safely read from the cache (i.e. there's no
revision
field for the precache manifest entry), the precaching request would still go to the network.While this is "safe", it's less efficient.
This change accounts for that, and will set
cache: 'default'
for those requests that could be safely satisfied by the HTTP cache, withcache: 'reload'
still being set for requests that should always ignore the cache and go against the network.