Update to the build libs JSDoc #2320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(This will need to be updated to use |
|
Have you run |
|
Yeah, I have. It's a big table, but I'm not exactly sure how much horizontal width it will end up needing until seeing how it looks staged on d.g.c. |
philipwalton
requested changes
Jan 13, 2020
|
Right. Now I'm remembering that when I made my JSDoc changes, I modified the WebFu gulp tasks to pull in my local Workbox changes rather than from the remote, so I could see what it would actually look like staged. But now I've reverted those changes, so I can't really share them. Probably worth updating the |
philipwalton
approved these changes
Jan 16, 2020
PR-Bot Size PluginChanged File Sizes
New FilesNo new files have been added. All File SizesView Table
Workbox Aggregate Size Plugin2.96KB gzip'ed (20% of limit) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @philipwalton
This updates the JSDocs for the
workbox-buildandworkbox-webpack-pluginpublic interfaces to match what's supported in v5.I am not 100% sure how JSDoc with that many options will look when rendered in our HTML, so it might need to be tweaked further prior to official publication. But... it should be accurate, at least!