Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to allow/denylist #2325

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Switch to allow/denylist #2325

merged 1 commit into from
Jan 13, 2020

Conversation

jeffposnick
Copy link
Contributor

R: @philipwalton

Use allow/deny terminology, with a custom error message for navigateFallbackWhitelist/navigateFallbackBlacklist build options letting folks know that they should switch.

Copy link
Member

@philipwalton philipwalton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jeremytenjo
Copy link

Please don't forget to update the docs as well
https://developers.google.com/web/tools/workbox/modules/workbox-webpack-plugin

@philipwalton
Copy link
Member

The docs changes are complete. They've been happening in this branch https://github.com/google/WebFundamentals/commits/workbox-v5, and are also tracked in this issue: #2122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants