fix: support for cookies in ContinueRequest #2370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lightning00Blade
force-pushed
the
support-cookies-in-request-continue
branch
3 times, most recently
from
5471c6b to
2213611
Compare
Lightning00Blade
force-pushed
the
support-cookies-in-request-continue
branch
2 times, most recently
from
4209c28 to
6eca328
Compare
sadym-chromium
approved these changes
Jul 17, 2024
Lightning00Blade
force-pushed
the
support-cookies-in-request-continue
branch
from
6eca328 to
9de9efb
Compare
|
@sadym-chromium there are WPT test for this, but the data they expect is not correct from our side, I am looking into it, happy to wait to merge this after that investigation. |
I think we can merge this and update the solution to finegrain it later |
Lightning00Blade
force-pushed
the
support-cookies-in-request-continue
branch
from
9de9efb to
39f11c4
Compare
OrKoN
pushed a commit
that referenced
this pull request
Jul 22, 2024
🤖 I have created a release *beep* *boop* --- ## [0.6.2](chromium-bidi-v0.6.1...chromium-bidi-v0.6.2) (2024-07-22) ### Bug Fixes * only auto-attach to a target once ([#2421](#2421)) ([7118b96](7118b96)) * support `default` for BeforeUnload prompt ([#2412](#2412)) ([f24ad85](f24ad85)) * support for cookies in ContinueRequest ([#2370](#2370)) ([0cd7e12](0cd7e12)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still need to see why the data is not surfacing on the request correctly, but the feature should now work.
The WPT test will pass once we fix the
request->headers.