Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only auto-attach to a target once #2421

Merged
merged 1 commit into from
Jul 22, 2024
Merged

fix: only auto-attach to a target once #2421

merged 1 commit into from
Jul 22, 2024

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Jul 17, 2024

This can be a workaround for #2420

@OrKoN OrKoN force-pushed the orkon/cdp-auto-attach branch from fcf64bb to 4cfe7c1 Compare July 18, 2024 09:53
@OrKoN
Copy link
Collaborator Author

OrKoN commented Jul 18, 2024

@sadym-chromium not ready for review

@sadym-chromium
Copy link
Collaborator

@sadym-chromium not ready for review

Can you please mark it as draft?

@OrKoN OrKoN force-pushed the orkon/cdp-auto-attach branch from 4cfe7c1 to 057fb34 Compare July 18, 2024 10:32
@OrKoN OrKoN marked this pull request as draft July 18, 2024 10:33
@OrKoN OrKoN requested review from sadym-chromium and removed request for sadym-chromium July 18, 2024 10:33
@OrKoN OrKoN force-pushed the orkon/cdp-auto-attach branch 2 times, most recently from 85dccfa to f67aed4 Compare July 18, 2024 11:18
@OrKoN OrKoN added the puppeteer Run Puppeteer test when added to PR label Jul 18, 2024
@OrKoN OrKoN closed this Jul 18, 2024
@OrKoN OrKoN reopened this Jul 18, 2024
@OrKoN OrKoN force-pushed the orkon/cdp-auto-attach branch 2 times, most recently from 93fbc4a to fa3154f Compare July 18, 2024 13:04
@OrKoN OrKoN marked this pull request as ready for review July 18, 2024 13:11
@OrKoN OrKoN requested a review from Lightning00Blade July 18, 2024 13:12
@OrKoN OrKoN force-pushed the orkon/cdp-auto-attach branch from fa3154f to efaf4bb Compare July 18, 2024 13:16
@OrKoN OrKoN force-pushed the orkon/cdp-auto-attach branch 4 times, most recently from d7afcfb to 427a639 Compare July 19, 2024 09:03
@OrKoN OrKoN force-pushed the orkon/cdp-auto-attach branch 2 times, most recently from 4a7898c to da4e913 Compare July 19, 2024 11:54
Copy link
Collaborator

@Lightning00Blade Lightning00Blade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OrKoN OrKoN force-pushed the orkon/cdp-auto-attach branch 3 times, most recently from 4f22300 to 72cf6bd Compare July 19, 2024 12:10
@OrKoN OrKoN force-pushed the orkon/cdp-auto-attach branch from 72cf6bd to 22ea11a Compare July 22, 2024 08:49
@OrKoN OrKoN enabled auto-merge (squash) July 22, 2024 08:49
@OrKoN OrKoN merged commit 7118b96 into main Jul 22, 2024
47 of 48 checks passed
@OrKoN OrKoN deleted the orkon/cdp-auto-attach branch July 22, 2024 08:56
OrKoN pushed a commit that referenced this pull request Jul 22, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.6.2](chromium-bidi-v0.6.1...chromium-bidi-v0.6.2)
(2024-07-22)


### Bug Fixes

* only auto-attach to a target once
([#2421](#2421))
([7118b96](7118b96))
* support `default` for BeforeUnload prompt
([#2412](#2412))
([f24ad85](f24ad85))
* support for cookies in ContinueRequest
([#2370](#2370))
([0cd7e12](0cd7e12))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
puppeteer Run Puppeteer test when added to PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants