-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: only auto-attach to a target once #2421
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
orkon/cdp-auto-attach
branch
from
July 18, 2024 09:53
fcf64bb
to
4cfe7c1
Compare
sadym-chromium
approved these changes
Jul 18, 2024
@sadym-chromium not ready for review |
Can you please mark it as draft? |
OrKoN
force-pushed
the
orkon/cdp-auto-attach
branch
from
July 18, 2024 10:32
4cfe7c1
to
057fb34
Compare
OrKoN
requested review from
sadym-chromium
and removed request for
sadym-chromium
July 18, 2024 10:33
OrKoN
force-pushed
the
orkon/cdp-auto-attach
branch
2 times, most recently
from
July 18, 2024 11:18
85dccfa
to
f67aed4
Compare
OrKoN
force-pushed
the
orkon/cdp-auto-attach
branch
2 times, most recently
from
July 18, 2024 13:04
93fbc4a
to
fa3154f
Compare
OrKoN
force-pushed
the
orkon/cdp-auto-attach
branch
from
July 18, 2024 13:16
fa3154f
to
efaf4bb
Compare
OrKoN
commented
Jul 18, 2024
OrKoN
force-pushed
the
orkon/cdp-auto-attach
branch
4 times, most recently
from
July 19, 2024 09:03
d7afcfb
to
427a639
Compare
OrKoN
commented
Jul 19, 2024
OrKoN
commented
Jul 19, 2024
OrKoN
force-pushed
the
orkon/cdp-auto-attach
branch
2 times, most recently
from
July 19, 2024 11:54
4a7898c
to
da4e913
Compare
Lightning00Blade
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
OrKoN
force-pushed
the
orkon/cdp-auto-attach
branch
3 times, most recently
from
July 19, 2024 12:10
4f22300
to
72cf6bd
Compare
OrKoN
commented
Jul 19, 2024
OrKoN
force-pushed
the
orkon/cdp-auto-attach
branch
from
July 22, 2024 08:49
72cf6bd
to
22ea11a
Compare
OrKoN
pushed a commit
that referenced
this pull request
Jul 22, 2024
🤖 I have created a release *beep* *boop* --- ## [0.6.2](chromium-bidi-v0.6.1...chromium-bidi-v0.6.2) (2024-07-22) ### Bug Fixes * only auto-attach to a target once ([#2421](#2421)) ([7118b96](7118b96)) * support `default` for BeforeUnload prompt ([#2412](#2412)) ([f24ad85](f24ad85)) * support for cookies in ContinueRequest ([#2370](#2370)) ([0cd7e12](0cd7e12)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be a workaround for #2420