Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict VM-instance network variables validation #1553

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

mr0re1
Copy link
Collaborator

@mr0re1 mr0re1 commented Jul 6, 2023

  • Remove default value for var.network_self_link;
  • Enforce setting exactly one of network_interfaces or network_self_link/subnetwork_self_link;

* Remove default value for `var.network_self_link`;
* Enforce setting exactly one of `network_interfaces` or `network_self_link/subnetwork_self_link`;
* Enforce setting at most one of `network_self_link` or `subnetwork_self_link`.
@mr0re1 mr0re1 requested a review from tpdownes July 6, 2023 21:41
modules/compute/vm-instance/main.tf Outdated Show resolved Hide resolved
@tpdownes tpdownes assigned mr0re1 and unassigned tpdownes Jul 10, 2023
@mr0re1 mr0re1 assigned tpdownes and unassigned mr0re1 Jul 10, 2023
@tpdownes tpdownes self-requested a review July 10, 2023 20:14
@tpdownes tpdownes assigned mr0re1 and unassigned tpdownes Jul 10, 2023
@mr0re1 mr0re1 merged commit cb08d22 into GoogleCloudPlatform:develop Jul 11, 2023
@mr0re1 mr0re1 deleted the vm_instance_val branch July 11, 2023 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants